Upgrade to PHPUnit 11 for PHP >= 8.2 and check deprecation messages #2902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the test suite to use PHPUnit 11 for PHP 8.2+ while maintaining PHPUnit 10 for PHP 8.1, enabling better deprecation message testing support.
Key changes:
- PHPUnit version constraint updated to allow both 10.x and 11.x
- Migration from deprecated PHPUnit methods and annotations to modern attributes
- Addition of deprecation handling for Symfony lazy ghost objects
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updates PHPUnit dependency constraint to support both version 10.5.58+ and 11.5.43+ |
| phpunit.xml.dist | Updates schema reference from PHPUnit 10.5 to 11.5 |
| tests/Tests/QueryTest.php | Replaces deprecated will($this->returnValue()) with willReturn() |
| tests/Tests/Functional/TargetDocumentTest.php | Migrates from docblock @doesNotPerformAssertions to attribute syntax |
| tests/Tests/Functional/ShardKeyTest.php | Adds guard to prevent accessing uninitialized logger in tearDown |
| tests/Tests/ConfigurationTest.php | Adds IgnoreDeprecations attribute to tests involving deprecated lazy ghost objects |
| tests/Tests/BaseTestCase.php | Reorders configuration logic to check native lazy object first before lazy ghost |
| .github/workflows/continuous-integration.yml | Adds conditional deprecation suppression for native proxy mode |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alcaeus
reviewed
Nov 11, 2025
Member
alcaeus
left a comment
alcaeus
left a comment
There was a problem hiding this comment.
Minor suggestion to avoid a conditional, but LGTM otherwise.
GromNaN
force-pushed
the
phpunit-11
branch
3 times, most recently
from
b26c6b8 to
4d5d0a9
Compare
alcaeus
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to test deprecation messages, we must use PHPUnit 9 with Symfony bridge or PHPUnit 11+.
This PR enable PHPUnit 11 with PHP 8.2+ (and keep 10 for PHP 8.1).
We have to ignore deprecation when Symfony lazy ghost are enabled, because the trait is deprecated.