Skip to content

Commit d484eb0

Browse files
committed
Address feedback from GH review
1 parent 3363e4b commit d484eb0

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

lib/Doctrine/ORM/Mapping/Driver/ReflectionBasedDriver.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
use Doctrine\ORM\Mapping\ClassMetadata;
88
use ReflectionProperty;
99

10+
/** @internal */
1011
trait ReflectionBasedDriver
1112
{
1213
/**

tests/Doctrine/Tests/ORM/Functional/Ticket/GH10449Test.php

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,14 @@ class GH10449Test extends OrmTestCase
1616
{
1717
public function testToManyAssociationOnMappedSuperclassShallBeRejected(): void
1818
{
19-
$em = $this->getTestEntityManager();
20-
$classes = [GH10449MappedSuperclass::class, GH10449Entity::class, GH10449ToManyAssociationTarget::class];
19+
$em = $this->getTestEntityManager();
2120

2221
$this->expectException(MappingException::class);
2322
$this->expectExceptionMessageMatches('/illegal to put an inverse side one-to-many or many-to-many association on mapped superclass/');
2423

25-
foreach ($classes as $class) {
26-
$cm = $em->getClassMetadata($class);
27-
}
24+
// Currently the ClassMetadataFactory performs the check only when loading the subclasses, this might change with
25+
// https://github.com/doctrine/orm/pull/10398
26+
$em->getClassMetadata(GH10449Entity::class);
2827
}
2928

3029
/**

0 commit comments

Comments
 (0)