Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token? (OAuth flow support) #7

Open
magnushasselquist opened this issue Dec 13, 2021 · 13 comments · Fixed by dogmatic69/nordigen-python#3
Open

Token? (OAuth flow support) #7

magnushasselquist opened this issue Dec 13, 2021 · 13 comments · Fixed by dogmatic69/nordigen-python#3
Labels
enhancement New feature or request

Comments

@magnushasselquist
Copy link

magnushasselquist commented Dec 13, 2021

Hi,
So happy I have found this integration.
From Nordigen I get "secret id", "secret key", and by using them I can retrieve the "access token" as well as a "refresh token".
What is in more detail, the "token" needed in the configuration, is it the id, key or access-token, as per above, or a combination?
/Magnus

@dogmatic69
Copy link
Owner

Ah, seems they have changed authentication. So previously you would just generate an API key and use it. Now there is a full oAuth flow.

I'll look into this and get it implemented.

@magnushasselquist
Copy link
Author

magnushasselquist commented Dec 13, 2021 via email

@dogmatic69
Copy link
Owner

Turned into a little bit of a project :D. New version posted soon 🤞🏻

dogmatic69 added a commit to dogmatic69/nordigen-python that referenced this issue Jan 6, 2022
Due to breaking changes introduced by v2 for oAuth support,
some hacking things done with depreciation warnings supporting
backwards compatibility.

When using secrets version will default to V2 which is not yet
tested / implemented for all endpoints. Will be supported
in the coming PRs in non-breaking way as possible.

This will resolve dogmatic69/nordigen-homeassistant#7
once the HA integration is updated
@dogmatic69 dogmatic69 reopened this Jan 7, 2022
dogmatic69 added a commit to dogmatic69/nordigen-python that referenced this issue Jan 7, 2022
Various endpoints changed so adding support for new
endpoints and redirecting old requests where possible
to avoid breaks.

Could still be issues with the actual data, will
look into that in a later PR.

Upgrade required to support OAuth flow in
dogmatic69/nordigen-homeassistant#7
@dogmatic69 dogmatic69 changed the title Token? Token? (OAuth flow support) Jan 8, 2022
@dogmatic69 dogmatic69 added the enhancement New feature or request label Jan 8, 2022
@dogmatic69
Copy link
Owner

dogmatic69 commented Jan 9, 2022

@magnushasselquist Mostly implemented now, I'll do a bit of testing with this new version and push a new integration release soon. 👌🏻

@magnushasselquist
Copy link
Author

magnushasselquist commented Jan 10, 2022 via email

@jbperrin88
Copy link

Hey ! Just to tell you that i'm really interested to ;p

@dogmatic69
Copy link
Owner

dogmatic69 commented Feb 22, 2022

It's mostly working but i've side tracked into config flow. I need to finalise as I want it too :D (maybe a bit of HACS is needed for installation).

The biggest side track though, was the 11000 SEK electricity bill in December, had to do some emergency heating automations which took a while to sort out as I had hardware issues :/

@magnushasselquist
Copy link
Author

Hi! Just to check on status :) Anything I could help out with?

@dogmatic69
Copy link
Owner

Yo, taken some time off this but was actually just looking at it over the weekend. Can't do too much till next week, will push something up then.

Last I recall just needing a bit more unit testing on the config flow and finalising the steps. The whole dev toolchain I was using was lame but I now found the integration blueprint so hopefully will be more fun to work on...

Let me migrate it all to that setup and then we can see what more is needed

@MikkelFrid
Copy link

Also very interested - hope you get it up and running! :-)

@dogmatic69
Copy link
Owner

Good news, I've got the code migrated and setup using the integration blueprint so there will be a better workflow for development and HACS support for easy install.

Most tests working, need to finish off the config flow.

@jbperrin88
Copy link

NICE !! looking forward to test it !

@pittbull
Copy link

pittbull commented Jan 2, 2024

Is this being implemented or is the add-on decommissioned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants