From 82b87ecc1ff4f7ede45df72fb95234c071de553e Mon Sep 17 00:00:00 2001 From: "Endi S. Dewata" Date: Tue, 11 Jul 2023 14:18:23 -0500 Subject: [PATCH] Fix NPE in UsrGrpAdminServlet In commit 11d268faa93dd3604292fa46e6895c4d6f197af9 the UsrGrpAdminServlet's constructor was modified to get the CMSEngine object from the servletContext before the field was initialized which triggered a NullPointerException. To fix the problem the code in the constructor has been moved into init() so that it will run after the servletContext initialization. https://issues.redhat.com/browse/RHEL-626 --- .../netscape/cms/servlet/admin/UsrGrpAdminServlet.java | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/base/server/src/main/java/com/netscape/cms/servlet/admin/UsrGrpAdminServlet.java b/base/server/src/main/java/com/netscape/cms/servlet/admin/UsrGrpAdminServlet.java index 3c2deb069f8..d4d65fd92f9 100644 --- a/base/server/src/main/java/com/netscape/cms/servlet/admin/UsrGrpAdminServlet.java +++ b/base/server/src/main/java/com/netscape/cms/servlet/admin/UsrGrpAdminServlet.java @@ -87,15 +87,6 @@ public class UsrGrpAdminServlet extends AdminServlet { private static final String MULTI_ROLE_ENABLE = "multiroles.enable"; private static final String MULTI_ROLE_ENFORCE_GROUP_LIST = "multiroles.false.groupEnforceList"; - /** - * Constructs User/Group manager servlet. - */ - public UsrGrpAdminServlet() { - super(); - CMSEngine engine = getCMSEngine(); - mAuthz = engine.getAuthzSubsystem(); - } - /** * Initializes this servlet. */ @@ -103,6 +94,7 @@ public UsrGrpAdminServlet() { public void init(ServletConfig config) throws ServletException { super.init(config); CMSEngine engine = getCMSEngine(); + mAuthz = engine.getAuthzSubsystem(); mMgr = engine.getUGSubsystem(); }