Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid emails are still accepted in add #1

Open
dohaduong opened this issue Apr 14, 2023 · 1 comment
Open

Invalid emails are still accepted in add #1

dohaduong opened this issue Apr 14, 2023 · 1 comment

Comments

@dohaduong
Copy link
Owner

dohaduong commented Apr 14, 2023

Using the command add n/John Day p/98765432 e/just@example a/John street, block 123,#01-01 m/computer science, the email is clearly invalid - just@example, where the domain is invalid, the app still accepts this as a valid email.

The DG appendix for planned enhancement has not mentioned this bug also, thus, I would say this is a feature flaw which could be improved in the future version as users should be prompted of the invalid email address similar to this.

image.png

@soc-pe-bot
Copy link

soc-pe-bot commented Apr 17, 2023

Team's Response

Both are concerned about the validity of invalid domains as an email input.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Invalid email with invalid domain are accepted

Using command add n/K e/[email protected], the app still accepts the email as an invalid email, even tho the domain is clearly invalid.

Thus, as the DG/UG did not mention anything regarding this, I will consider this as a feature flaw

image.png


[original: nus-cs2103-AY2223S2/pe-interim#1077] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We accept this as a feature flaw however we believe that this is not in scope for these reasons:

  • Emails are hardly the main aspect of TeamBuilder.
  • Most users are unlikely to use IP address in their emails.
  • This is a foreseeable future enhancement
  • When users tries to send an email to an invalid email address, they will know right away.

Emails are also difficult to check for due to the many possible variations. Below is an excerpt of valid email addresses according to wikipedia:
image.png

We believe that this is more of a 'nice to have feature' than a feature flaw

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

  • I disagree

Reason for disagreement: I disagree that these 2 bug reports are duplicates, this is because one of them has invalid domain as a combination of number ("111.222..."), whereas the other one only contains letters ("@example").

I have specifically separated these 2 bug reports as the input and the error itself is different.


❓ Issue response

Team chose [response.NotInScope]

  • I disagree

Reason for disagreement: The team did not mention in both UG and DG that they will be improving/fixing/taking into account the complexity of valid email domain/email and thus, I would still consider this a valid feature flaw.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants