-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datepicker is in Cyrillic after upgrade #6
Comments
It includes its own jquery datepicker, while DokuWiki includes also a date picker. |
Hmm, quick look in the recent commits, show one with changes of the javascript. The javascript of the datetimepicker is not touch, but of the fullcalender is, and it includes updates of the languages of the fullcalender. A limit set of languages is allowed here: https://github.com/dokufreaks/dokuwiki-plugin-davcal/blob/master/action/jsinfo.php |
I founded this ....
<script src='lib/moment.js'></script> <script src='lib/jquery-ui.custom-datepicker.js'></script> <script src='fullcalendar/fullcalendar.js'></script> <script src='fullcalendar/lang-all.js'></script> I think that this is the problem the header of the
The calendar works correctly in english ... If i put the row with |
Hi there, Any ideas how to fix it and still have syncing working? Thanks a lot! |
I have not enough time to look into this, my guess is that it could also possibly interfere with the datepicker included in DokuWiki (but that is pure guessing). Who has javascript experience and could investigate this? That would be helpful! |
I've used this workaround to fix it : changed the header in the file
with this lines
|
Hi, I've seen and tried it. After the embedded calendar disappears. No workaround for me. Sadly. |
I had the same issue. And it comes as no suprise, all this plugin and jQuery mess, specially with datepicker, just cannot be relied on. This mess is not the fault of any one individual plugin! It's a general issue with the plugin environment. As we see in this thread it effects many plugins and pops up here and there. Plus, at least in the case of datepicker, also browsers will interfer. And I cannot present my users with 10 different datepickers! I fixed this whole mess by explicitely declaring the datepicker object and with it all the options of datepicker in all effected plugins in the respective JS files of those plugins (copy&paste). Finally, I managed to establish my custom styled datepicker accross all plugins (bureaucracy, struct, booking) for a consistent user experience. This was alot of work. (Too much to post it here, but that's the idea.) I am aware it is kind of a workaround. But I feel save now! Take home messages:
(PS: Initially, I had tried out davcal and ended up using yearbox and minical. And I didn't notice, at the time, where this bug came from. It was just very persistent. I should have deactivated plugins, to tackle this. But, I didn't. That's why I had to take the hard way to solve this problem for me.) |
Valid point. Please note that this plugin is in need of a maintainer. This repository is recently created to enable others to submit easier improvements for this plugin. Because it needs significant improvement, it is marked as discontinued. Maybe a wider use of the input with type date or datetime in DokuWiki and it’s plugins could improve the scattered set of datetime fields? |
Well, this will also look different in different browsers. The jQuery datepicker, if declared explicitely, looks identical in all browsers. DokuWiki is very much in need of a set of working calendars for different applications. I programmed one booking calendar for the booking plugin, one full year wallpaper calendar from yearbox, one monthly leave calendar with navigation and input form from yearbox, and I enhanced minical for room reservation. So this was alot of work, to make DokuWiki usable as an intranet. All of this was only halfbaked available. |
How did you declare the jQuery date picker? Or could you propose it with a pull request? |
As an example, in most major plugins, datepicker is declared very bare, like so: This leaves too much room for unwanted cross-talk. What I did was specify all properties that I need, like so in EVERY plugin:
So, however this could be implemented in the code, I don't know, but leaving it to quincidence is just not a solution, as we saw earlier. |
I dug a bit deeper into this, and I found that davcal loads some https://codesearch.dokuwiki.org/xref/plugin/davcal/script.js The last loaded However, you can move your langage to the end of the list or just delete all other locale language calls, except the one for your language, which you keep. And your language will now be used for davcal and bureaucracy alike. So to make the point clear: this is actually, where the language setting is overwritten, causing this bug in bureaucracy! |
Hi all ! after the upgrade to
2022-07-31a "Igor"
, my datepicker pop up on bureaucracy is in cyrillic. I don't understand how to change it. After many trials i found out that if i disable the davcal plugin datepicker return in english (my local settings).Is there a method to change the datepicker language ?
The text was updated successfully, but these errors were encountered: