Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjUpdate Funcs of HSD Incorrectly Use enum_t instead of unsigned int #758

Open
PsiLupan opened this issue Mar 15, 2023 · 2 comments
Open

Comments

@PsiLupan
Copy link
Collaborator

As discussed on Discord, the ObjUpdate functions of various HSD types were changed to have enum_t for the type argument, when it is in fact an unsigned int that uses a list of #define rather than an enum. An example of this is MObjUpdateFunc.

This branch addresses some of that in commits as well as incorrect prototype declarations that were part of CObj, if someone wants to cherry-pick them. master...PsiLupan:melee:cobj-match

@ribbanya
Copy link
Collaborator

Do you know of a particular function that fails with signed?

@PsiLupan
Copy link
Collaborator Author

At this point, I haven't seen any. But that's more likely because calls to these are through function pointers being passed up a chain, so the compiler happened to optimize them differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants