Port updated Refactoring Browser code from Pharo #265
Labels
Comments
blairmcg
added a commit
that referenced
this issue
Dec 23, 2016
In the visitor pattern the visitee should "accept" the visitor, and the visitor should "visit" the visitee. The names of most of the visiting methods in the StProgramNodeVisitor hierarchy did not follow this pattern. This is work in progress related to #265 and should make it easier to determine what has changed in the Refactoring Browser code.
blairmcg
added a commit
that referenced
this issue
Dec 24, 2016
In the visitor pattern the visitee should "accept" the visitor, and the visitor should "visit" the visitee. The names of most of the visiting methods in the StProgramNodeVisitor hierarchy did not follow this pattern. This is work in progress related to #265 and should make it easier to determine what has changed in the Refactoring Browser code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At a very cursory glance, it looks like the version of the Refactoring Browser parser and related code has seen significant updates since it was ported to Dolphin. There's some cool stuff there—a unified (and renamed) formatting engine, some interesting-looking improvements to the parse nodes themselves...and I haven't even looked at the Refactorings proper (though they might prove much harder to port).
Has any thought been given to bringing some of these improvements to Dolphin? I know there were compatibility issues when it was initially ported, but it seems like it ought to be possible to handle many of them in a way that will work both places (and contribute those fixes back to the Pharo project, if they are amenable), or by adding Dolphin-specific subclasses in an additional package (as is already done with e.g. DolphinAddMethodChange).
The text was updated successfully, but these errors were encountered: