Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop .NET 6 #3183

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Drop .NET 6 #3183

wants to merge 2 commits into from

Conversation

martincostello
Copy link
Collaborator

Drop support for .NET 6.

Resolves #3087.

Leaving in draft for now - it's best to ship after a period of stability where we've fixed any known regressions caused by v7.

@martincostello martincostello added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code version-major A change suitable for release in a major version labels Nov 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.58%. Comparing base (164b910) to head (73e018f).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3183   +/-   ##
=======================================
  Coverage   83.58%   83.58%           
=======================================
  Files          76       76           
  Lines        3161     3161           
  Branches      536      536           
=======================================
  Hits         2642     2642           
  Misses        519      519
Flag Coverage Δ
Linux 83.58% <ø> (ø)
Windows 83.58% <ø> (ø)
macOS 83.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello added this to the v8.0.0 milestone Nov 27, 2024
Saibamen
Saibamen reviewed Nov 28, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Saibamen
Copy link
Contributor

Saibamen commented Nov 28, 2024 •
edited
Loading

Please remove all #if NET6_0_OR_GREATER and #if NET7_0_OR_GREATER.

And if these IF statements have ELSE, update check to #if NET8_0_OR_GREATER. <----- EDIT: Umm, no, this is Swashbuckle.AspNetCore, not NSwag :D - we are not supporting .NET Framework

image

@martincostello
Copy link
Collaborator Author

martincostello commented Nov 28, 2024 •
edited
Loading

No, that's unnecessary code churn that makes no difference just changing the version numbers.

The elses may be removable in some cases, but only for projects that don't target netstandard2.0.

martincostello and others added 2 commits January 21, 2025 08:58
@martincostello
Drop .NET 6
61edc95 
Drop support for .NET 6.
Resolves #3087.
@mesMess @Saibamen @martincostello
Update README.md
73e018f 
Co-authored-by: Adam Stachowicz <[email protected]>
@martincostello martincostello mentioned this pull request Feb 6, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saibamen Saibamen Saibamen left review comments

@mesMess mesMess mesMess approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code version-major A change suitable for release in a major version
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.

Drop support for .NET 6
4 participants
@martincostello @codecov-commenter @Saibamen @mesMess