Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for short clarification on design principles #50

Open
1kastner opened this issue Dec 30, 2021 · 4 comments
Open

Request for short clarification on design principles #50

1kastner opened this issue Dec 30, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@1kastner
Copy link
Contributor

Description

Other modules, such as https://github.com/agronholm/sphinx-autodoc-typehints, also extend the options of the sphinx documentation. However, they do not use decorators in the code. Instead, they listen to sphinx events. This way, only the people who build the docs need to have the module installed. When using the decorator approach like in this module, each user needs to install it just to run the code. Furthermore, the decorators are invoked every time the the module is imported, even if it is only used programmatically and no documentation is required. What were the reasons that led to this decorator-based module design? A small explanation in the Readme would be very great! Thank you very much for the clarification.

@stale
Copy link

stale bot commented Jun 29, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 29, 2022
@1kastner
Copy link
Contributor Author

@domdfcoding did you find some time to have a look at this?

@1kastner
Copy link
Contributor Author

I would favor if the decorator only turned active while the documentation is generated. Could it be a no-op while the actual program runs?

@1kastner
Copy link
Contributor Author

@domdfcoding any chance?

@stale stale bot removed the stale label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants