Support for proxy models #220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
django-moderations creates a LEFT OUTER JOIN query but uses the content type ID for the concrete class, even on the proxy class model managers. To play nicely, we tell the ModeratedObject model to save only the concrete class' content type ID. I also noticed proxy class queries breaking if you register both the concrete class and the proxy class. Simply changing the order seems to work but I have no idea why.
|
90a71f1 doesn't quite solve what I thought it did so back to square two for now. |
|
I have abandoned work on this. I couldn't find a way for the concrete class to return objects of all types (the default behavior in a concrete + proxy class setup on Django). Proxy classes worked fine but the concrete class was a no-go. |
|
Hi @MaybeThisIsRu , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #218
Fixes #219