Skip to content

Commit e8e2b39

Browse files
committed
Updated contribution guidelines to explicitely state that any code contribution should include new tests.
1 parent d9eba75 commit e8e2b39

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

CONTRIBUTING.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,8 @@ following rules before you submit a pull request:
114114
to other methods available in scikit-learn.
115115

116116
- Documentation and high-coverage tests are necessary for enhancements to be
117-
accepted. Bug-fixes or new features should be provided with
117+
accepted. We encourage you to add new test(s) as it's relatively rare for any code
118+
contributions not to require test(s). Bug-fixes or new features should be provided with
118119
[non-regression tests](https://en.wikipedia.org/wiki/Non-regression_testing).
119120
These tests verify the correct behavior of the fix or feature. In this
120121
manner, further modifications on the code base are granted to be consistent

doc/developers/contributing.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -825,7 +825,8 @@ each pull request needs to be signed off by two core developers, you can speed
825825
up this process by providing your feedback.
826826

827827
Here are a few important aspects that need to be covered in any code review,
828-
from high-level questions to a more detailed check-list.
828+
from high-level questions to a more detailed check-list. We encourage you to add new
829+
test(s) as it's relatively rare for any code contributions not to require test(s).
829830

830831
- Do we want this in the library? Is it likely to be used? Do you, as
831832
a scikit-learn user, like the change and intend to use it? Is it in

0 commit comments

Comments
 (0)