Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute paths #3

Open
jdixon-86 opened this issue Aug 24, 2016 · 5 comments
Open

Absolute paths #3

jdixon-86 opened this issue Aug 24, 2016 · 5 comments

Comments

@jdixon-86
Copy link

I don't see how this handles applications being in virtual directories (subfolder). From my experience (unless i'm missing something) it will always try to render the path to the root.

So if I have https://www.domain.com/myapp then it generates the css/ to https://www.domain.com/_style when it should be https://www.domain.com/myapp/_style

Am I missing something?

@donnyv
Copy link
Owner

donnyv commented Aug 24, 2016

It never writes anything to disk. It keeps the compressed and obfuscated
files all in memory. It keeps it speedy.

On Aug 23, 2016 9:34 PM, "Jacob Dixon" [email protected] wrote:

I don't see how this handles applications being in virtual directories
(subfolder). From my experience (unless i'm missing something) it will
always try to render the path to the root.

So if I have https://www.domain.com/myapp then it generates the css/ to
https://www.domain.com/_style when it should be
https://www.domain.com/myapp/_style

Am I missing something?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#3, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACHwPf2o4s6CBj9Eexs6sxGdontDVjBeks5qi5-4gaJpZM4JrjbI
.

@jdixon-86
Copy link
Author

jdixon-86 commented Aug 24, 2016

Yes but when you are dealing with virtuals directories it has to get the path correct. Take a look here: https://cpdemo.compsyscloud.com/cloudpanel

You can see the @BundleItAssets.RenderCSS("login") is generating:
<link rel="stylesheet" type="text/css" href="/_style/login.9D6BCD90DF857CBEF9C9B7BB03448164B6C77101.css">

when it actually should generate:

<link rel="stylesheet" type="text/css" href="/CloudPanel/_style/login.9D6BCD90DF857CBEF9C9B7BB03448164B6C77101.css">

The path in your request handler will process /CloudPanel/_style/......:

Get["/" + settings.StylePath + "/{bundlename}.{hash}.css"] = parameters =>

@donnyv
Copy link
Owner

donnyv commented Aug 24, 2016

It looks like a relative path issue. This is what the path is resolving too.

On Aug 23, 2016 9:57 PM, "Jacob Dixon" [email protected] wrote:

Yes but when you are dealing with virtuals directories it has to get the
path correct. Take a look here: https://cpdemo.compsyscloud.com/cloudpanel

You can see the @BundleItAssets.RenderCSS("login") is generating: when it
actually should generate:

The path in your request handler will process /CloudPanel/_style/......:

Get["/" + settings.StylePath + "/{bundlename}.{hash}.css"] = parameters =>


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#3 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACHwPQ0gF2_nu5kj-lU49sEJaxKaKZAJks5qi6TrgaJpZM4JrjbI
.

@jdixon-86
Copy link
Author

Yeah. So the @BundleItAssets.RenderCSS (and JS) needs to format the path correctly.

@donnyv
Copy link
Owner

donnyv commented Aug 24, 2016

For now I would just use the source from Github and fix it on your end.
When I get some time I'll have to fix this and check it against different
types of site setups.
Domain level versus nested.

Thanks for letting me know.

On Tue, Aug 23, 2016 at 11:02 PM, Jacob Dixon [email protected]
wrote:

Yeah. So the @BundleItAssets.RenderCSS (and JS) needs to format the path
correctly.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#3 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACHwPQqX7GYTbcsdyGHmj-iMpYGjEPHpks5qi7RagaJpZM4JrjbI
.

Donny V.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants