Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monokai theme #184

Closed
seagle0128 opened this issue May 15, 2018 · 9 comments
Closed

Add monokai theme #184

seagle0128 opened this issue May 15, 2018 · 9 comments
Labels
is:feature Adds or requests new features, or extends existing ones is:theme Requests that a theme be added or removed

Comments

@seagle0128
Copy link
Contributor

seagle0128 commented May 15, 2018

I love doom-themes very much because it makes me focus on contents.
I know doom-molokai is great and I like it. But I love monokai-theme since it's lighter and warmer.
monokai-theme is amazing, so is it impossible to support it in doom-themes?

image

@hlissner hlissner added the is:theme Requests that a theme be added or removed label May 22, 2018
@ema2159
Copy link
Contributor

ema2159 commented Feb 28, 2020

There's a PR (#413), so it may be included soon.

@seagle0128
Copy link
Contributor Author

Thank you.

@hlissner hlissner added the is:feature Adds or requests new features, or extends existing ones label Mar 4, 2020
@hlissner hlissner changed the title Support monokai theme Add monokai theme Mar 4, 2020
@ema2159
Copy link
Contributor

ema2159 commented Mar 12, 2020

@seagle0128 given that there's been quite some interest for Monokai themes, I decided to simply transform Molokai into Monokai classic, given that the palette is the same and it's just the UI that changes.

@brunosmmm
Copy link

brunosmmm commented Mar 13, 2020

Why remove molokai completely? Just updated my packages and restarted to a broken setup because of this.

Edit: @ema2159 by the way, what do you mean palette is same / UI changes? Monokai looks quite different from my earlier molokai setup

@ema2159
Copy link
Contributor

ema2159 commented Mar 13, 2020

@brunosmmm I felt it was too similar to Monokai classic, but if you want I can bring it back!

@brunosmmm
Copy link

@ema2159 It's up to you, I can use monokai just fine. Here's a side-by-side comparison to show how different they are, just for more info:

monomolo.png

@ema2159
Copy link
Contributor

ema2159 commented Mar 13, 2020

@brunosmmm I'll bring it back then!

@DanielRichtmann
Copy link
Contributor

I'd be happy if you brought it back and just have them coexist.

@ema2159
Copy link
Contributor

ema2159 commented Mar 13, 2020

@brunosmmm @DanielRichtmann it's back!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
is:feature Adds or requests new features, or extends existing ones is:theme Requests that a theme be added or removed
Projects
None yet
Development

No branches or pull requests

5 participants