doom-sourcerer breaks if doom-sourcerer-brighter-modeline is enabled

[aguiliano]

Theme(s)

doom-sourcerer

What were you expecting?

The doom-sourcerer theme works without any issues as long as doom-sourcerer-brighter-modeline is nil. However, If I (setq doom-sourcerer-brighter-modeline t) before loading the theme, emacs reverts to the default theme and drops an error in the minibuffer

What actually happened?

Debugger entered--Lisp error: (void-variable modeline-bg)
  (if doom-sourcerer-brighter-modeline modeline-bg (cons (doom-darken (car bg) 0.15) (cdr base1)))
  (let* ((bold doom-themes-enable-bold) (italic doom-themes-enable-italic) (bg '...) (bg-alt '...) (base0 '...) (base1 '...) (base2 '...) (base3 '...) (base4 '...) (base5 '...) (base6 '...) (base7 '...) (base8 '...) (fg '...) (fg-alt '...) (grey '...) (red '...) (orange '...) (green '...) (green-br '...) (teal '...) (yellow '...) (blue '...) (dark-blue '...) (magenta '...) (violet '...) ...) (setq doom-themes--colors (list (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) (cons ... ...) ...)) (custom-declare-theme 'doom-sourcerer 'doom-sourcerer-theme "A dark theme based off of ...") (custom-theme-set-faces 'doom-sourcerer (list 'bold (list ... ... ...)) (list 'bold-italic (list ...)) (list 'italic (list ...)) (list 'escape-glyph (list ... ... ...)) (list 'default (list ... ... ...)) (list 'fringe (list ... ... ...)) (list 'region (list ... ... ...)) (list 'highlight (list ... ... ...)) (list 'cursor (list ... ... ...)) (list 'shadow (list ... ... ...)) (list 'minibuffer-prompt (list ... ... ...)) (list 'tooltip (list ... ... ...)) (list 'secondary-selection (list ... ... ...)) (list 'lazy-highlight (list ... ... ... ... ... ...)) (list 'match (list ... ... ...)) (list 'trailing-whitespace (list ... ... ...)) (list 'nobreak-space (list ...)) (list 'vertical-border (list ... ... ...)) (list 'link (list ... ... ...)) (list 'error (list ... ... ...)) (list 'warning (list ... ... ...)) (list 'success (list ... ... ...)) (list 'font-lock-builtin-face (list ... ... ...)) (list 'font-lock-comment-face (list ... ... ...)) ...) (custom-theme-set-variables 'doom-sourcerer (list 'ansi-color-names-vector (vconcat ...)) (list 'rustic-ansi-faces (vconcat ...)) (list 'exwm-floating-border-color (doom-color ...)) (list 'fci-rule-color (doom-color ...)) (list 'jdee-db-spec-breakpoint-face-colors (list ... ... ...)) (list 'jdee-db-requested-breakpoint-face-colors (list ... ... ...)) (list 'jdee-db-active-breakpoint-face-colors (list ... ... ...)) (list 'highlight-tail-colors (list ... ...)) (list 'objed-cursor-color (doom-color ...)) (list 'pdf-view-midnight-colors (list ... ... ...)) (list 'vc-annotate-color-map (list ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ...)) (list 'vc-annotate-very-old-color nil) (list 'vc-annotate-background (doom-color ...))) (if bold nil (set-face-bold 'bold nil)) (if italic nil (set-face-italic 'italic nil)) (provide-theme 'doom-sourcerer))
  eval-buffer(#<buffer  *load*> nil "/home/andrew/.emacs.d/elpa/doom-themes-20220622.23..." nil t)  ; Reading at buffer position 6294
  load-with-code-conversion("/home/andrew/.emacs.d/elpa/doom-themes-20220622.23..." "/home/andrew/.emacs.d/elpa/doom-themes-20220622.23..." nil t)
  load("/home/andrew/.emacs.d/elpa/doom-themes-20220622.23..." nil t nil t)
  load-theme(doom-sourcerer t)
  (progn (load-theme 'doom-sourcerer t))
  eval((progn (load-theme 'doom-sourcerer t)) t)
  elisp--eval-last-sexp(nil)
  eval-last-sexp(nil)
  funcall-interactively(eval-last-sexp nil)
  call-interactively(eval-last-sexp nil nil)
  command-execute(eval-last-sexp)

Steps to reproduce

completely empty ~/.emacs.d other than the init.el below:

;; add melpa package repository for use-package
(require 'package)
(add-to-list 'package-archives
	     '("melpa" . "https://melpa.org/packages/"))
(package-initialize)

;; load use-package
(unless (package-installed-p 'use-package)
  (package-refresh-contents)
  (package-install 'use-package))
(require 'use-package)
(setq use-package-always-ensure t)

;; load doom-themes
(use-package doom-themes)
(setq doom-sourcerer-brighter-modeline t)
(load-theme 'doom-sourcerer t)

package info:

    Version: 20220622.2317
     Commit: d79a41f593c69697af1ddaac971c0c47ecc446a8

Operating system

Arch Linux

Emacs version

emacs 28.1-7 (standard arch emacs package, no native comp)

Installed commit of doom-themes

d79a41f