No colors on magit-ediff-compare

[rakanalh]

Theme(s)

doom-tomorrow-night

What were you expecting?

When invoking magit-ediff-compare, the expected behavior is to show the diffs in similar colors as the ones used in Magit's dashboard.

What actually happened?

The diff colors in tomorrow-night are barely visible since the theme is dark. Doom-one highlights are a bit better but don't use colors when i tried to compare.

Steps to reproduce

1. Switch to doom-tomorrow-night theme.
2. Invoke magit-ediff-compare on a file that was changed.
3. Observe that highlighs are not very visible and it's hard to tell what was removed, added, changed.

Operating system

Arch Linux

Emacs version

31.0.50

Installed commit of doom-themes

7bc39f2c1402794e76ea10b781dfe586fed7253b

[hlissner]

Please provide a screenshot.

Observe that highlighs are not very visible and it's hard to tell what was removed, added, changed.

The message here seems different from the title. Are the colors hard to see or are there no colors at all?

[rakanalh]

Magit status:

Magit-ediff-compare:

The message here seems different from the title. Are the colors hard to see or are there no colors at all?

Sorry if that's the case. I meant to say that they're hard to see. It would be very optimal if the colors used are green/red similar to the ones we see in magit status... but if that's not the desired result for other people, making the highlighting a easier to see (brighter on this dark theme?) would be good as well.

Thank you.