Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

potential unset variable used in rdpdr #72

Open
danieltrentman opened this issue May 11, 2015 · 0 comments
Open

potential unset variable used in rdpdr #72

danieltrentman opened this issue May 11, 2015 · 0 comments

Comments

@danieltrentman
Copy link

diff -wb rdpdr-old.m rdpdr.m
797a798

      if (prev != NULL)

Need to test prev before assignment in while loop:

RDAsynchronousIORequest *iorq = conn->fileInfo[fd].firstIORequest, *prev;

while (iorq != NULL)
{
if (iorq == requestToRemove)
{
if (prev != NULL)
prev->next = iorq->next;
xfree(requestToRemove);
return iorq->next;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danieltrentman