Skip to content
This repository has been archived by the owner on Feb 21, 2020. It is now read-only.

Improved highlight movement ++ #43

Open
midsbie opened this issue May 25, 2018 · 1 comment
Open

Improved highlight movement ++ #43

midsbie opened this issue May 25, 2018 · 1 comment
Assignees

Comments

@midsbie
Copy link
Collaborator

midsbie commented May 25, 2018

  1. User can move through set of highlights if there are 2 or more highlights which are visible on the page
  2. Highlight movement should consist of: (i) ordering highlights by position on page, which may not necessarily coincide with position in the DOM; and (ii) ignoring invisible highlights by inspecting bounding box and testing for 0 height, which is believed should catch majority of cases

(1) above simply requires the test outlined in (1.ii) to be conducted for two highlights.

Implementing this issue should greatly improve the UX of highlight movement.

@midsbie midsbie self-assigned this May 25, 2018
@midsbie
Copy link
Collaborator Author

midsbie commented May 25, 2018

  1. Also center horizontally if out of bounds

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant