Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrimeNG v17: Fix SelectButton issues #29661

Closed
Tracked by #29058
nicobytes opened this issue Aug 20, 2024 · 0 comments · Fixed by #29674
Closed
Tracked by #29058

PrimeNG v17: Fix SelectButton issues #29661

nicobytes opened this issue Aug 20, 2024 · 0 comments · Fixed by #29674
Assignees
@hmoreras
Labels
Merged QA : Not Needed Team : Falcon Type : Refactoring

Comments

@nicobytes
Copy link
Contributor

nicobytes commented Aug 20, 2024 •
edited
Loading

Parent Issue

#29058

Goal

There are issues with the SelectButton component and PrimeNG v17.

Screenshots

v15 v17
Screenshot 2024-08-20 at 11 27 25 AM Screenshot 2024-08-20 at 11 27 20 AM

Additional info

The branch for this card must be from epic-primeng-upgrade, and the PR must target that branch.
@nicobytes nicobytes mentioned this issue Aug 20, 2024
Closed
@nicobytes nicobytes moved this from New to Current Sprint Backlog in dotCMS - Product Planning Aug 20, 2024
@hmoreras hmoreras self-assigned this Aug 20, 2024
@hmoreras hmoreras moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Aug 20, 2024
nicobytes pushed a commit that referenced this issue Aug 20, 2024
@hmoreras
implementation(PrimeNG-17): #29661 Fix SelectButton issues (#29674)
ff35059 
### Proposed Changes
* add the `p-buttonset` rules

### Screenshots
Before: 
<img width="327" alt="image"
src="https://github.com/user-attachments/assets/8dc80802-c974-4876-9288-74c76e302f59">


After: 

<img width="294" alt="image"
src="https://github.com/user-attachments/assets/6eed9fd8-10d4-4ae5-b47a-861a4daff3c4">
@nicobytes nicobytes linked a pull request Aug 20, 2024 that will close this issue
implementation(PrimeNG-17): #29661 Fix SelectButton issues #29674
Merged
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Aug 20, 2024
@nicobytes nicobytes moved this from Internal QA to Done in dotCMS - Product Planning Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmoreras hmoreras

Labels
Merged QA : Not Needed Team : Falcon Type : Refactoring
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implementation(PrimeNG-17): #29661 Fix SelectButton issues dotCMS/core
2 participants
@nicobytes @hmoreras