Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many to One Relationship Not Maintained When Copied to New Host #29938

Closed
patrick-schweiger opened this issue Sep 9, 2024 · 2 comments · Fixed by #30161
Closed

Many to One Relationship Not Maintained When Copied to New Host #29938

patrick-schweiger opened this issue Sep 9, 2024 · 2 comments · Fixed by #30161
Assignees
@dsilvam @jcastro-dotcms
Labels
dotCMS : Content Management OKR : Customer Success Owned by Arno OKR : Customer Support Owned by Scott QA : Approved QA : Passed Internal Release : 23.01.24 Included in LTS patch release 23.01.24 Release : 23.10.24 v18 Included in LTS patch release 23.10.24 v18 Release : 24.04.24 v10 Included in LTS patch release 24.04.24 v10 Release : 24.10.02 Bug Fixing Team : Falcon Type : Defect

Comments

@patrick-schweiger
Copy link

patrick-schweiger commented Sep 9, 2024 •
edited
Loading

Parent Issue

#29256

Problem Statement

When parent and child content exists on another host, a Many to One Relationship is not being maintained when a site is copied to another host.

This is currently impacting a customer and seems to be an outlier as this does not appear to be an issue with other cardinalities.

Steps to Reproduce

To test in the demo site, copy the demo site.

  • Create the many to one relationship field on a content type. Screenshot 2024-09-09 at 4 37 56 PM

  • Then create a content item with the parent on Site A and the child (related content, in this case the Activity pictured below) on Site B.
    Screenshot 2024-09-09 at 4 32 57 PM

  • Use the site copy tool, copying Site A with all objects checked. When reviewing this new copied site and looking at parent content item that was copied, you will see the relationship is no longer present.
    Screenshot 2024-09-09 at 4 36 56 PM

Acceptance Criteria

When parent and child content exists on another host, a Many to One Relationship should be maintained when a site is copied to another host.

dotCMS Version

latest current release, demo, all lts versions

Proposed Objective

Customer Success

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

https://dotcms.slack.com/archives/C035XMEDQ4F/p1725904713408219
Generated from a customer request.

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@john-thomas-dotcms john-thomas-dotcms moved this from New to Current Sprint Backlog in dotCMS - Product Planning Sep 18, 2024
@jcastro-dotcms jcastro-dotcms self-assigned this Sep 24, 2024
jcastro-dotcms added a commit that referenced this issue Sep 26, 2024
@jcastro-dotcms
fix(Site Copy) fixes #29938 : Many-to-One Relationship Not Maintained…
127d754 
… When Contentlet is Copied to New Site
@jcastro-dotcms jcastro-dotcms linked a pull request Sep 26, 2024 that will close this issue
fix(Site Copy) fixes #29938 : Many-to-One Relationship Not Maintained When Contentlet is Copied to New Site #30161
Merged
@jcastro-dotcms jcastro-dotcms moved this from In Progress to In Review in dotCMS - Product Planning Sep 26, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 26, 2024
@jcastro-dotcms
fix(Site Copy) fixes #29938 : Many-to-One Relationship Not Maintained…
81d923d 
… When Contentlet is Copied to New Site (#30161)

### Proposed Changes
* Many-to-One relationships were not being copied correctly when the
parent Contentlet lived in a Site different than any of the ones
involved in the Site Copy operation. That is, when the parent Contentlet
lived under System Host or a Site that is neither the source nor the
destination Site.
* This is a variation of the previous issue reported earlier:
  * #29256
* This code change fixes both scenarios.
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Sep 26, 2024
@github-actions github-actions bot mentioned this issue Sep 26, 2024
Merged
@dsilvam dsilvam self-assigned this Sep 27, 2024
erickgonzalez added a commit that referenced this issue Sep 27, 2024
@erickgonzalez
#29938 include in 23.01.24 LTS
53d1f91
@dsilvam
Copy link
Contributor

dsilvam commented Sep 27, 2024

Passed Internal QA.

Followed the steps in the description using the same Content Types and after copying the original demo site, the copied version included the Banner Carousel contentlet with the related Activity.

Image

@dsilvam dsilvam moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Sep 27, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on ** trunk_62799e6**, Docker, macOS 14.5, FF v126.0.1

@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Sep 27, 2024
@erickgonzalez erickgonzalez added the Next LTS Release Shortlisted of issues that will be included in the upcoming LTS label Oct 1, 2024
erickgonzalez added a commit that referenced this issue Oct 23, 2024
@erickgonzalez
#29938 include in 24.04.24 LTS
755ee4b
erickgonzalez added a commit that referenced this issue Oct 23, 2024
@erickgonzalez
#29938 include in 23.10.24 LTS
23ee021
@erickgonzalez erickgonzalez added Release : 23.01.24 Included in LTS patch release 23.01.24 Release : 23.10.24 v18 Included in LTS patch release 23.10.24 v18 Release : 24.04.24 v10 Included in LTS patch release 24.04.24 v10 and removed Next LTS Release Shortlisted of issues that will be included in the upcoming LTS labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsilvam dsilvam

@jcastro-dotcms jcastro-dotcms

Labels
dotCMS : Content Management OKR : Customer Success Owned by Arno OKR : Customer Support Owned by Scott QA : Approved QA : Passed Internal Release : 23.01.24 Included in LTS patch release 23.01.24 Release : 23.10.24 v18 Included in LTS patch release 23.10.24 v18 Release : 24.04.24 v10 Included in LTS patch release 24.04.24 v10 Release : 24.10.02 Bug Fixing Team : Falcon Type : Defect
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
6 participants
@dsilvam @erickgonzalez @jcastro-dotcms @john-thomas-dotcms @josemejias11 @patrick-schweiger