Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Main Tabs for Edit Contentlent #30022

Closed
Tracked by #30012
oidacra opened this issue Sep 16, 2024 · 4 comments · Fixed by #30324
Closed
Tracked by #30012

Implement Main Tabs for Edit Contentlent #30022

oidacra opened this issue Sep 16, 2024 · 4 comments · Fixed by #30324

Comments

@oidacra
Copy link
Member

oidacra commented Sep 16, 2024

Parent Issue

#30012

Task

Implement the main tabs for the Edit Contentlent interface according to the final design specifications.

Proposed Objective

Technical User Experience

Proposed Priority

Priority 2 - Important

Acceptance Criteria

  1. Implement the final design of the tabs in the new Edit Contentlet
Screenshot 2024-09-16 at 12 20 21 PM
@oidacra oidacra changed the title Implement the design of the main Tabs Implement Main Tabs for Edit ContentLent Sep 16, 2024
@oidacra oidacra moved this from New to Next 1-3 Sprints in dotCMS - Product Planning Oct 2, 2024
@oidacra oidacra changed the title Implement Main Tabs for Edit ContentLent Implement Main Tabs for Edit Contentlent Oct 2, 2024
@oidacra oidacra self-assigned this Oct 2, 2024
oidacra added a commit that referenced this issue Oct 23, 2024
oidacra added a commit that referenced this issue Oct 23, 2024
oidacra added a commit that referenced this issue Oct 23, 2024
oidacra added a commit that referenced this issue Oct 23, 2024
oidacra added a commit that referenced this issue Oct 23, 2024
oidacra added a commit that referenced this issue Oct 23, 2024
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Oct 23, 2024
@dsilvam dsilvam assigned dsilvam and unassigned oidacra Oct 23, 2024
@oidacra oidacra reopened this Oct 23, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Oct 23, 2024
@oidacra oidacra moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Oct 23, 2024
@oidacra
Copy link
Member Author

oidacra commented Oct 23, 2024

Internal QA Steps

1. Contentlet Operations

  • - Create a new contentlet and verify it saves properly
  • - Edit the saved contentlet and confirm changes are maintained
  • - Check that all fields are saving correctly - Category field not saving. Error reported on a separate issue

2. Tab Display Rules

  • Single Tab:

  • 1. Create a content type with only the default Content tab

  • 2. Verify no tab navigation appears

  • 3. Check all content is visible and accessible

  • Multiple Tabs:

  • 1. Create a content type with 2+ tabs

  • 2. Verify both Content tab and custom tab(s) are visible

  • 3. Check you can switch between tabs normally

3. Back Button Navigation

  • - Work on a content type
  • - Click back button
  • - Verify it returns to the correct content type you were working on

4. Sidebar Controls

  • - Click open/close sidebar buttons
  • - Verify sidebar opens and closes correctly
  • - Check it works from different sections

@dsilvam
Copy link
Contributor

dsilvam commented Oct 24, 2024

Passed Internal QA.
I am capturing small style details that can be worked on GD.

Design: blue font for selected
Image

Implementation: black font for selected
Image

Design: hover area smaller with radius
Image

Implementation: bigger over area without radius
Image

@dsilvam dsilvam moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Oct 24, 2024
@josemejias11
Copy link
Contributor

Failed: Tested on trunk_fe2a36c, Docker, macOS 14.5, FF v126.0.1

When switching an already existing content like blogs to the new Edit, some of the already existing tabs are not getting throughout the change

New
Screenshot 2024-10-29 at 1 58 35 PM

Old
Screenshot 2024-10-29 at 2 00 08 PM

@josemejias11 josemejias11 moved this from QA - In Progress to QA - Rejected in dotCMS - Product Planning Oct 29, 2024
@josemejias11 josemejias11 moved this from QA - Rejected to Current Sprint Backlog in dotCMS - Product Planning Oct 29, 2024
@josemejias11 josemejias11 moved this from Current Sprint Backlog to QA - Backlog in dotCMS - Product Planning Oct 29, 2024
@josemejias11 josemejias11 moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning Oct 29, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on trunk_fe2a36c, Docker, macOS 14.5, FF v126.0.1

Feedback from above will be place in the new sidebar feature.

@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Oct 29, 2024
@dsilvam dsilvam closed this as completed Oct 30, 2024
@github-project-automation github-project-automation bot moved this from Done to Internal QA in dotCMS - Product Planning Oct 30, 2024
@dsilvam dsilvam moved this from Internal QA to Done in dotCMS - Product Planning Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment