Skip to content
This repository has been archived by the owner on Dec 16, 2019. It is now read-only.

max-height for dynamic lists #447

Open
ShukiB opened this issue Nov 23, 2017 · 0 comments
Open

max-height for dynamic lists #447

ShukiB opened this issue Nov 23, 2017 · 0 comments

Comments

@ShukiB
Copy link

ShukiB commented Nov 23, 2017

Currently there is the option to set the height of the ul.
In my case and in for many other people the list of item to be is not a fixed list.
If i set the height for 250px for instance and i get only 1 item, the list will be empty.
The solution is to implement a max-height instead of height, that way the ul will be the same height as the list until the max-height specified.

I have fiddled with the concept a bit and found that it only requires to change the attribute to max-height (of course need to change var names for obvious reasons).
from this:
In the template: 'height' : settings.scrollable ? settings.scrollableHeight : 'auto'

to this:
In the template: 'max-height' : settings.scrollable ? settings.scrollableHeight : 'auto'

p.s. : there might be more cases but i didn't have time to check all cases.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant