-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Fragment-arguments/experimental features #3209
Comments
Sounds interesting! About
|
also, are there changes needed in Codegen? |
by the way, my thinking here is not to use an experimental version of graphql-js, but to use our own implementation of parse |
For sure, we can use that parse fn in everywhere so codegen, mesh and hive can benefit from. |
Is your feature request related to a problem? Please describe.
I have been picking up the Fragment Arguments spec for GraphQL, however it is hard to find a good testbed for this outside of the reference implementation.
My goal with this would be for much like we do with JS-features to already implement it in a few clients/servers.
@graphql-tools/execute
The above imply that we'd implement the custom executor/validator/... as part of the
execute
used inGraphQL-Yoga
and that inurql
we'd still leveragegraphql.web
to parse fragment arguments.That being said we're still faced with the issue of how to
parse
GraphQL requests in Yoga to accomodate for Fragment Arguments.Describe the solution you'd like
We add support for
experimentalFragmentArguments
in GraphQL Yoga and we can allow folks to adopt it throughurql
(or anyone else choosing to adopt it) as a GraphQL Client. This gives us a window of feedback to advance the spec.The text was updated successfully, but these errors were encountered: