Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom model binder for methods with more than one parameter are not documented well enough #13387

Closed
guardrex opened this issue Jul 18, 2019 — with docs.microsoft.com · 7 comments
Labels
doc-enhancement Pri1 High priority, do before Pri2 and Pri3 Source - Docs.ms Docs Customer feedback via GitHub Issue
Milestone

Comments

Copy link
Collaborator

guardrex commented Jul 18, 2019

From @arieradle ...

Issue description

Custom model binder for methods with more than one parameter are not documented well enough.
Please refer this question:
https://stackoverflow.com/questions/56883548/custom-model-binder-for-a-webapi-method-with-more-than-one-parameter

Software versions

Check the .NET target framework(s) being used, and include the version number(s).

  • [x ] .NET Framework - 462

Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@Rick-Anderson
Copy link
Contributor

@serpent5 It looks like I just need to add your SO answer to this doc.

@Rick-Anderson Rick-Anderson self-assigned this Jul 19, 2019
@Rick-Anderson Rick-Anderson added the Pri1 High priority, do before Pri2 and Pri3 label Jul 19, 2019
@Rick-Anderson Rick-Anderson added this to the Backlog milestone Jul 19, 2019
@serpent5
Copy link
Contributor

@Rick-Anderson Would you like me to take a stab at this?

@Rick-Anderson
Copy link
Contributor

@serpent5 yes!

@serpent5
Copy link
Contributor

serpent5 commented Jul 27, 2019

@Rick-Anderson This article is really old and the sample app targets 1.0 😱, which means it doesn't have any of the more recent API conventions ([ApiController], ControllerBase, etc). Do you know if there's an issue for getting this all updated?

The question I answered was very specific to having the [ApiController] attribute in place, but the document in question doesn't mention [ApiController] so I'm unsure about updating the sample app to include an example that demonstrates the problem. I'm also aware that sample apps are generally being dropped...

@Rick-Anderson
Copy link
Contributor

Upgrading to 2.2 and 3.0 would be ideal

@Rick-Anderson
Copy link
Contributor

See #13529

@Rick-Anderson
Copy link
Contributor

Moved to #16319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-enhancement Pri1 High priority, do before Pri2 and Pri3 Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
None yet
Development

No branches or pull requests

5 participants