Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

author is null #15470

Closed
Legends opened this issue Nov 3, 2019 — with docs.microsoft.com · 4 comments
Closed

author is null #15470

Legends opened this issue Nov 3, 2019 — with docs.microsoft.com · 4 comments
Labels
Source - Docs.ms Docs Customer feedback via GitHub Issue ⌚ Not Triaged

Comments

Copy link

Legends commented Nov 3, 2019

In your sample app author is null, means doesn't get bound.
Shouldn't it get bound?

Calling: http://localhost:xxxx/api/boundAuthors/get/1
author is null:

// GET: api/boundauthors/get/1
        #region demo2
        [HttpGet("get/{authorId}")]
        public IActionResult Get(Author author)
        {
            return Ok(author);
        }
        #endregion


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@dotnet-bot dotnet-bot added ⌚ Not Triaged Source - Docs.ms Docs Customer feedback via GitHub Issue labels Nov 3, 2019
@guardrex
Copy link
Collaborator

guardrex commented Nov 3, 2019

@Rick-Anderson On a broader point, this sample is one of the lingering 1.0 sample apps remaining 🤦‍♂. It's on the list ... #5495.

@Legends Legends closed this as completed Nov 3, 2019
@Legends Legends reopened this Nov 3, 2019
@guardrex
Copy link
Collaborator

guardrex commented Nov 3, 2019

I'm not sure if this is something that can be addressed using the existing sample. Yes, let's leave it open just in case the behavior can be addressed without updating the sample.

If it turns out that this can't be addressed, then we can close this as a dup of the sample update tracking issue (#5495).

EDIT I'll make a cross-link on the sample update tracking issue to this for visibility.

@Legends
Copy link
Author

Legends commented Nov 3, 2019

This one is a dup of #10341

@guardrex
Copy link
Collaborator

guardrex commented Nov 3, 2019

Oh ... ok. I'll relink the sample tracking issue to that one both issues.

I presume that it's a P2 doc bug because it's one of the topics that doesn't receive nearly as much traffic as the others, and we're 🏃😅 right now with high priority work.

@guardrex guardrex closed this as completed Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source - Docs.ms Docs Customer feedback via GitHub Issue ⌚ Not Triaged
Projects
None yet
Development

No branches or pull requests

3 participants