Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading samples #16362

Closed
Youssef1313 opened this issue Jan 1, 2020 · 1 comment
Closed

Downloading samples #16362

Youssef1313 opened this issue Jan 1, 2020 · 1 comment

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Jan 1, 2020

Many articles links to samples on GitHub. Example is ASP.NET Core SignalR JavaScript client.

In the "How to download" link, it suggests to download the whole repo, which isn't a good solution. It would be much much better to migrate these samples to the samples browser, so it allows to download ONLY the required sample.

The process of migration isn't too difficult, it only requires a README.md with special metadata.

An example of a PR that migrated a sample to the samples browser is #13808

Note: The PR was missing a required metadata, ('urlFragment'), which was added later. So, if someone will work on this, don't take the metadata section as is without adding the urlFragment.

Note 2: I don't know if there is already an issue open for the same task. If there is one already, you can close this one.

@guardrex
Copy link
Collaborator

guardrex commented Jan 1, 2020

Hello @Youssef1313 ... Yes, we're aware. We haven't had the call from management yet here to do the work. I don't have an ETA at this time. This work may or may not be tied to a new issue. We keep a sample update tracking issue, so we might use that one for this work. Indeed, some of the sample moves might include versioning work as well, so it might make sense to track using that one 👉 #5495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants