Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not latest version INCLUDE breaks on out-of-support moniker line #34100

Closed
guardrex opened this issue Nov 13, 2024 · 5 comments · Fixed by #34108
Closed

Not latest version INCLUDE breaks on out-of-support moniker line #34100

guardrex opened this issue Nov 13, 2024 · 5 comments · Fixed by #34108

Comments

@guardrex
Copy link
Collaborator

guardrex commented Nov 13, 2024

@Rick-Anderson @tdykstra @wadepickett

I went to activate the not-latest version INCLUDE in my >=8.0 articles, but the newer out-of-support section of the INCLUDE breaks the file ...

Line 6: [Warning] No intersection between zone and file level monikers. The result of zone level range string '= aspnetcore-7.0 || = aspnetcore-5.0 || = aspnetcore-3.0 || = aspnetcore-3.1 || = aspnetcore-2.0' is 'aspnetcore-2.0', 'aspnetcore-3.0', 'aspnetcore-3.1', 'aspnetcore-5.0', 'aspnetcore-7.0', while file level monikers is 'aspnetcore-10.0', 'aspnetcore-8.0', 'aspnetcore-9.0'.

That section of the file can't be there until .NET 9 (STS) falls out of support (i.e., a || = aspnetcore-9.0 is added to the conditional) for any >=8.0 articles, so either that section of the file has to go, or I'll need to create a Blazor-specific version of the file without that section. Which way do you want me to go to solve it? 👂

@tdykstra
Copy link
Contributor

What is different about the Blazor docs compared to the non-Blazor docs?

@guardrex
Copy link
Collaborator Author

New Blazor articles came in at 8.0 for >=8.0, so I assume that there were no new articles added to the main doc set for this to break earlier.

I can add a new INCLUDE just for Blazor if you guys want.

@guardrex
Copy link
Collaborator Author

Perhaps, a new INCLUDE in the main doc set just for new 8.0 articles would be best. It would be the same as the existing file but without the out-of-support content in it.

@guardrex
Copy link
Collaborator Author

guardrex commented Nov 13, 2024

🤔

I wonder if parentheses are supported in these ranges?

:::moniker range="< aspnetcore-9.0 && (= aspnetcore-7.0 || = aspnetcore-5.0 || = aspnetcore-3.0 || = aspnetcore-3.1 || = aspnetcore-2.0)"

I guess that's worth a shot, but I think it's going to 💥. I'll find out ...... brb ...........

No 🎲🎲

Invalid moniker range: Parse ends before reaching end of string, unrecognized string: ' && (= aspnetcore-7.0 || = aspnetcore-5.0 || = aspnetcore-3.0 || = aspnetcore-3.1 || = aspnetcore-2.0)'.

#34105

@guardrex
Copy link
Collaborator Author

I'll add a file to move this forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants