Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace M.A.All meta-package with Microsoft.AspNetCore.App - MD files only #5314

Closed
Rick-Anderson opened this issue Jan 30, 2018 · 12 comments
Closed
Assignees
Labels
Pri1 High priority, do before Pri2 and Pri3
Milestone

Comments

@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented Jan 30, 2018

image

currently mentioned in 22 files. This issue is about updating the docs that specifically mention Microsoft.AspNetCore.All

We need to convert a few of these and agree on the language and style of the update.

Updating the samples that use the ALL meta-package is a lower priority. See Update all 2.0 samples to use M.A.App, aka Microsoft.AspNetCore.App #6382

@guardrex
Copy link
Collaborator

For reference: aspnet/Announcements#287

@scottaddie
Copy link
Member

scottaddie commented Jan 31, 2018

@guardrex client-side\spa-services.md isn't project.json-based. You can remove that one from your list above, if that's what it's tracking.

@rachelappel
Copy link
Contributor

@guardrex I looked at the environments and error-handling docs and I don't see any references to "Microsoft.AspNetCore.All" in those.

@guardrex
Copy link
Collaborator

guardrex commented Jan 31, 2018

[2X EDIT 😄] "Replace ALL meta-package with App Microsoft.AspNetCore.App - MD files only" ... I missed the "MD files only" bit. I'm pulling the data for when we have an issue that pertains to samples.

@rachelappel
Copy link
Contributor

Oh geez I forgot to look at the samples and hit just the docs.

@guardrex
Copy link
Collaborator

guardrex commented Jan 31, 2018

I totally missed what @Rick-Anderson was asking for here. I thought we'd do both ... fix the doc AND fix the sample. My bad. I think the samps will be a different issue. When we set that up tho ... I'll paste that table back in.

[EDIT] As this issue stands, I think only one of us really needs to breeze thru and fix the MD files. Really shouldn't take all that long (guessing).

@Rick-Anderson Rick-Anderson changed the title Replace ALL meta-package wit App Microsoft.AspNetCore.App - MD files only Replace M.A.All meta-package with Microsoft.AspNetCore.App - MD files only May 12, 2018
@Rick-Anderson
Copy link
Contributor Author

@guardrex what's the state of this issue?

@guardrex
Copy link
Collaborator

I was working the update for topics+samples simultaneously; but as u know, 2.1 sample updates on #5495 have been slow. Would you like me to run thru and get the last few of these out of the topics (and we'll get the samples done later)?

@Rick-Anderson
Copy link
Contributor Author

@guardrex no hurry, just wanted to get the state. It's not a priority.

@guardrex
Copy link
Collaborator

ok ... I'll get it. It's going to take a while longer to get samples squared away, so we may as well go ahead. I think (hope) that less than a dozen topics need a touch to drop it out of the text (with versioning, of course). The samples associated with those topics may still use the All package, and we can fix them up as we go on sample updates.

@guardrex guardrex added the Pri1 High priority, do before Pri2 and Pri3 label Oct 17, 2018
@guardrex
Copy link
Collaborator

@Rick-Anderson @scottaddie @tdykstra I'm ready to proceed on this issue today, but let me get the word on if there was a design change. The last info that I have is no version on the App package ...

#8579 (comment)
dotnet/sdk#2533

@guardrex
Copy link
Collaborator

Ok ... we're good ... no version for the time being ... #9129 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pri1 High priority, do before Pri2 and Pri3
Projects
None yet
Development

No branches or pull requests

4 participants