Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual updates and fix for issue 1041 androidx.camera #1042

Merged
merged 9 commits into from
Nov 15, 2024

Conversation

moljac
Copy link
Contributor

@moljac moljac commented Nov 12, 2024

Fix for #1041

@moljac moljac self-assigned this Nov 12, 2024
@moljac
Copy link
Contributor Author

moljac commented Nov 12, 2024

Moved to other PR

Unit Test errors

========================================
all-packages-tests
========================================
  Determining projects to restore...
  Restored ./tests/allpackages/AllPackagesTests.csproj (in 10,18 sec).
  AllPackagesTests -> ./tests/allpackages/bin/Debug/net8.0/AllPackagesTests.dll
Test run for ./tests/allpackages/bin/Debug/net8.0/AllPackagesTests.dll (.NETCoreApp,Version=v8.0)
VSTest version 17.11.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
  Failed TestAndroidDotNetAllPackages [1 m 29 s]
  Error Message:
   Command 'build -c Release -bl' failed with exit code 1.
Errors:
AMM0000: ./output/tests/allpackages/android/AllPackagesTest/obj/Release/net8.0-android/lp/920/jl/AndroidManifest.xml Warning: [./output/tests/allpackages/android/AllPackagesTest/AllPackagesTest.csproj]
AMM0000: Namespace 'org.chromium.net' used in: AndroidManifest.xml, AndroidManifest.xml, AndroidManifest.xml, AndroidManifest.xml. [./output/tests/allpackages/android/AllPackagesTest/AllPackagesTest.csproj]
AMM0000: ./output/tests/allpackages/android/AllPackagesTest/obj/Release/net8.0-android/lp/877/jl/AndroidManifest.xml Warning: [./output/tests/allpackages/android/AllPackagesTest/AllPackagesTest.csproj]
AMM0000: Namespace 'org.tensorflow.lite.support' used in: AndroidManifest.xml, AndroidManifest.xml. [./output/tests/allpackages/android/AllPackagesTest/AllPackagesTest.csproj]
AMM0000: [./output/tests/allpackages/android/AllPackagesTest/AllPackagesTest.csproj]
AMM0000: Attribute meta-data#androidx.car.app.CarAppMetadataHolderService.CAR_HARDWARE_MANAGER@value value=(androidx.car.app.hardware.AutomotiveCarHardwareManager) from AndroidManifest.xml:43:17-87 [./output/tests/allpackages/android/AllPackagesTest/AllPackagesTest.csproj]
AMM0000: is also present at AndroidManifest.xml:33:17-86 value=(androidx.car.app.hardware.ProjectedCarHardwareManager). [./output/tests/allpackages/android/AllPackagesTest/AllPackagesTest.csproj]
AMM0000: Suggestion: add 'tools:replace="android:value"' to <meta-data> element at AndroidManifest.xml to override. [./output/tests/allpackages/android/AllPackagesTest/AllPackagesTest.csproj]
AMM0000: Directory 'obj/Release/net8.0-android/lp/920' is from 'cronet-embedded.aar'. [./output/tests/allpackages/android/AllPackagesTest/AllPackagesTest.csproj]
AMM0000: Directory 'obj/Release/net8.0-android/lp/877' is from 'tensorflow-lite-support-api.aar'. [./output/tests/allpackages/android/AllPackagesTest/AllPackagesTest.csproj]
Warnings:
APT2000: warn: removing resource com.companyname.AllPackagesTest:string/action_bar_expand_collapse_button without required default value. [./output/tests/allpackages/android/AllPackagesTest/AllPackagesTest.csproj]
: [./output/tests/allpackages/android/AllPackagesTest/AllPackagesTest.csproj]
: [./output/tests/allpackages/android/AllPackagesTest/AllPackagesTest.csproj]

  Stack Trace:
     at AllPackagesTests.TestAllIndividualPackages.RunAndAssertSuccess(String arguments, String workingDir, Boolean isMSBuild) in ./tests/allpackages/TestAllIndividualPackages.cs:line 296
   at AllPackagesTests.TestAllIndividualPackages.TestAllPackages(String template, Boolean isGps) in ./tests/allpackages/TestAllIndividualPackages.cs:line 176
   at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.BlockUntilCompleted()
   at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter)
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func`1 invoke)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
   at NUnit.Framework.Internal.Execution.SimpleWorkItem.<>c__DisplayClass4_0.<PerformWork>b__0()
   at NUnit.Framework.Internal.ContextUtils.<>c__DisplayClass1_0`1.<DoIsolated>b__0(Object _)

  Failed TestMauiAllPackages [1 m 33 s]
  Error Message:
   Command 'build -c Release -bl' failed with exit code 1.
Errors:
AMM0000: ./output/tests/allpackages/maui/AllPackagesTest/obj/Release/net8.0-android/lp/931/jl/AndroidManifest.xml Warning: [./output/tests/allpackages/maui/AllPackagesTest/AllPackagesTest.csproj::TargetFramework=net8.0-android]
AMM0000: Namespace 'org.chromium.net' used in: AndroidManifest.xml, AndroidManifest.xml, AndroidManifest.xml, AndroidManifest.xml. [./output/tests/allpackages/maui/AllPackagesTest/AllPackagesTest.csproj::TargetFramework=net8.0-android]
AMM0000: ./output/tests/allpackages/maui/AllPackagesTest/obj/Release/net8.0-android/lp/889/jl/AndroidManifest.xml Warning: [./output/tests/allpackages/maui/AllPackagesTest/AllPackagesTest.csproj::TargetFramework=net8.0-android]
AMM0000: Namespace 'org.tensorflow.lite.support' used in: AndroidManifest.xml, AndroidManifest.xml. [./output/tests/allpackages/maui/AllPackagesTest/AllPackagesTest.csproj::TargetFramework=net8.0-android]
AMM0000: [./output/tests/allpackages/maui/AllPackagesTest/AllPackagesTest.csproj::TargetFramework=net8.0-android]
AMM0000: Attribute meta-data#androidx.car.app.CarAppMetadataHolderService.CAR_HARDWARE_MANAGER@value value=(androidx.car.app.hardware.ProjectedCarHardwareManager) from AndroidManifest.xml:33:17-86 [./output/tests/allpackages/maui/AllPackagesTest/AllPackagesTest.csproj::TargetFramework=net8.0-android]
AMM0000: is also present at AndroidManifest.xml:43:17-87 value=(androidx.car.app.hardware.AutomotiveCarHardwareManager). [./output/tests/allpackages/maui/AllPackagesTest/AllPackagesTest.csproj::TargetFramework=net8.0-android]
AMM0000: Suggestion: add 'tools:replace="android:value"' to <meta-data> element at AndroidManifest.xml to override. [./output/tests/allpackages/maui/AllPackagesTest/AllPackagesTest.csproj::TargetFramework=net8.0-android]
AMM0000: Directory 'obj/Release/net8.0-android/lp/931' is from 'cronet-embedded.aar'. [./output/tests/allpackages/maui/AllPackagesTest/AllPackagesTest.csproj::TargetFramework=net8.0-android]
AMM0000: Directory 'obj/Release/net8.0-android/lp/889' is from 'tensorflow-lite-support.aar'. [./output/tests/allpackages/maui/AllPackagesTest/AllPackagesTest.csproj::TargetFramework=net8.0-android]
Warnings:
APT2000: warn: removing resource com.companyname.allpackagestest:string/action_bar_expand_collapse_button without required default value. [./output/tests/allpackages/maui/AllPackagesTest/AllPackagesTest.csproj::TargetFramework=net8.0-android]
: [./output/tests/allpackages/maui/AllPackagesTest/AllPackagesTest.csproj::TargetFramework=net8.0-android]
: [./output/tests/allpackages/maui/AllPackagesTest/AllPackagesTest.csproj::TargetFramework=net8.0-android]

  Stack Trace:
     at AllPackagesTests.TestAllIndividualPackages.RunAndAssertSuccess(String arguments, String workingDir, Boolean isMSBuild) in ./tests/allpackages/TestAllIndividualPackages.cs:line 296
   at AllPackagesTests.TestAllIndividualPackages.TestAllPackages(String template, Boolean isGps) in ./tests/allpackages/TestAllIndividualPackages.cs:line 176
   at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.BlockUntilCompleted()
   at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter)
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func`1 invoke)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
   at NUnit.Framework.Internal.Execution.SimpleWorkItem.<>c__DisplayClass4_0.<PerformWork>b__0()
   at NUnit.Framework.Internal.ContextUtils.<>c__DisplayClass1_0`1.<DoIsolated>b__0(Object _)


Failed!  - Failed:     2, Passed:     2, Skipped:     0, Total:     4, Duration: 5 m 19 s - AllPackagesTests.dll (net8.0)
An error occurred when executing task 'all-packages-tests'.
Error: .NET CLI: Process returned an error (exit code 1).
do

@moljac moljac marked this pull request as draft November 12, 2024 18:13
@moljac moljac linked an issue Nov 12, 2024 that may be closed by this pull request
@moljac moljac changed the title Manual updates and fix for issue 1041 `androidx.camera Manual updates and fix for issue 1041 androidx.camera Nov 12, 2024
@moljac moljac requested a review from jpobst November 13, 2024 17:24
@moljac moljac marked this pull request as ready for review November 13, 2024 17:25
AndroidX.Camera.Extensions
AndroidX.Camera.Extensions.Internal
AndroidX.Camera.Extensions.Internal.Compat.Quirk
AndroidX.Camera.Extensions.Internal.Compat.Workaround
AndroidX.Camera.Lifecycle
AndroidX.Camera.Mlkit.Vision
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MLKit

@@ -288,11 +288,15 @@ AndroidX.Camera.Core.Processing.Concurrent
AndroidX.Camera.Core.Processing.Util
AndroidX.Camera.Core.ResolutionSelector
AndroidX.Camera.Core.StreamSharing
AndroidX.Camera.Effects
AndroidX.Camera.Effects.Internal
AndroidX.Camera.Effects.Opengl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenGL

@moljac moljac merged commit 45c65ed into main Nov 15, 2024
6 checks passed
@moljac moljac deleted the mu-20241112-issue-1041-camera-mlkit-vision branch November 15, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bind "androidx.camera:camera-mlkit-vision"
2 participants