Skip to content

Commit db32587

Browse files
grendellogrendello
committed
Fix after rebase
1 parent 6cbfa18 commit db32587

File tree

14 files changed

+125
-191
lines changed

14 files changed

+125
-191
lines changed

‎Xamarin.Android.sln‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,8 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "proguard-android", "src\pro
127127
EndProject
128128
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "native-clr", "src\native\native-clr.csproj", "{39F49484-872A-489D-8E6B-3BC532DD571D}"
129129
EndProject
130+
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.Android.Runtime.NativeAOT", "src\Microsoft.Android.Runtime.NativeAOT\Microsoft.Android.Runtime.NativeAOT.csproj", "{E8831F32-11D7-D42C-E43C-711998BC357A}"
131+
EndProject
130132
Global
131133
GlobalSection(SolutionConfigurationPlatforms) = preSolution
132134
Debug|AnyCPU = Debug|AnyCPU
@@ -353,6 +355,10 @@ Global
353355
{39F49484-872A-489D-8E6B-3BC532DD571D}.Debug|AnyCPU.Build.0 = Debug|Any CPU
354356
{39F49484-872A-489D-8E6B-3BC532DD571D}.Release|AnyCPU.ActiveCfg = Release|Any CPU
355357
{39F49484-872A-489D-8E6B-3BC532DD571D}.Release|AnyCPU.Build.0 = Release|Any CPU
358+
{E8831F32-11D7-D42C-E43C-711998BC357A}.Debug|AnyCPU.ActiveCfg = Debug|Any CPU
359+
{E8831F32-11D7-D42C-E43C-711998BC357A}.Debug|AnyCPU.Build.0 = Debug|Any CPU
360+
{E8831F32-11D7-D42C-E43C-711998BC357A}.Release|AnyCPU.ActiveCfg = Release|Any CPU
361+
{E8831F32-11D7-D42C-E43C-711998BC357A}.Release|AnyCPU.Build.0 = Release|Any CPU
356362
EndGlobalSection
357363
GlobalSection(SolutionProperties) = preSolution
358364
HideSolutionNode = FALSE
@@ -413,6 +419,7 @@ Global
413419
{5E806C9F-1B67-4B6B-A6AB-258834250DBB} = {FFCF518F-2A4A-40A2-9174-2EE13B76C723}
414420
{5FD0133B-69E5-4474-9B67-9FD1D0150C70} = {FFCF518F-2A4A-40A2-9174-2EE13B76C723}
415421
{39F49484-872A-489D-8E6B-3BC532DD571D} = {FFCF518F-2A4A-40A2-9174-2EE13B76C723}
422+
{E8831F32-11D7-D42C-E43C-711998BC357A} = {04E3E11E-B47D-4599-8AFC-50515A95E715}
416423
EndGlobalSection
417424
GlobalSection(ExtensibilityGlobals) = postSolution
418425
SolutionGuid = {53A1F287-EFB2-4D97-A4BB-4A5E145613F6}

‎src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.targets‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@
2626
<Import Project="Microsoft.Android.Sdk.BundledVersions.targets" />
2727
<Import Project="Microsoft.Android.Sdk.DefaultProperties.targets" />
2828
<Import Project="$(MSBuildThisFileDirectory)..\tools\Xamarin.Android.Common.Debugging.props"
29-
Condition="Exists('$(MSBuildThisFileDirectory)..\tools\Xamarin.Android.Common.Debugging.props')"/>
29+
Condition="Exists('$(MSBuildThisFileDirectory)..\tools\Xamarin.Android.Common.Debugging.props') And '$(DesignTimeBuild)' != 'true' "/>
30+
<Import Project="Microsoft.Android.Sdk.CoreCLR.targets" Condition=" '$(_AndroidRuntime)' == 'CoreCLR' " />
3031
<Import Project="Microsoft.Android.Sdk.NativeAOT.targets" Condition=" '$(_AndroidRuntime)' == 'NativeAOT' " />
3132

3233
</Project>

‎src/Xamarin.Android.Build.Tasks/Microsoft.NET.Sdk.Android/WorkloadManifest.in.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
],
1616
"platforms": [ "win-x64", "win-arm64", "linux-x64", "linux-arm64", "osx-x64", "osx-arm64" ],
1717
"extends" : [
18-
"microsoft-net-runtime-android-net8",
19-
"microsoft-net-runtime-android-aot-net8",
18+
"microsoft-net-runtime-android-net9",
19+
"microsoft-net-runtime-android-aot-net9",
2020
"microsoft-net-runtime-android",
2121
"microsoft-net-runtime-android-aot"
2222
]

‎src/Xamarin.Android.Build.Tasks/Tasks/CollectAssemblyFilesForArchive.cs‎

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,7 @@ public class CollectAssemblyFilesToCompress : AndroidTask
2222
[Required]
2323
public string AssemblyCompressionDirectory { get; set; } = "";
2424

25-
[Required]
26-
public ITaskItem[] ResolvedRuntimePacks { get; set; } = Array.Empty<ITaskItem> ();
27-
28-
[Required]
29-
public string ApkOutputPath { get; set; } = "";
30-
31-
[Required]
32-
public string AppSharedLibrariesDir { get; set; } = "";
25+
public bool EmbedAssemblies { get; set; }
3326

3427
[Required]
3528
public bool EnableCompression { get; set; }
@@ -62,9 +55,9 @@ public override bool RunTask ()
6255
ResolvedFrameworkAssembliesOutput = ResolvedFrameworkAssemblies;
6356
ResolvedUserAssembliesOutput = ResolvedUserAssemblies;
6457

65-
DSOWrapperGenerator.Config dsoWrapperConfig = DSOWrapperGenerator.GetConfig (Log, AndroidBinUtilsDirectory, ResolvedRuntimePacks, IntermediateOutputPath);
66-
bool compress = !IncludeDebugSymbols && EnableCompression;
67-
IDictionary<AndroidTargetArch, Dictionary<string, CompressedAssemblyInfo>>? compressedAssembliesInfo = null;
58+
// We aren't going to compress any assemblies
59+
if (IncludeDebugSymbols || !EnableCompression || !EmbedAssemblies)
60+
return true;
6861

6962
var assemblies_to_compress = new List<ITaskItem> ();
7063
var compressed_assemblies_info = GetCompressedAssemblyInfo ();

‎src/Xamarin.Android.Build.Tasks/Tasks/GenerateJavaStubs.cs‎

Lines changed: 27 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,14 @@ public class GenerateJavaStubs : AndroidTask
9696
[Required]
9797
public string AndroidRuntime { get; set; } = "";
9898

99+
public string CodeGenerationTarget { get; set; } = "";
100+
101+
[Required]
102+
public string TargetName { get; set; } = "";
103+
104+
AndroidRuntime androidRuntime;
105+
JavaPeerStyle codeGenerationTarget;
106+
99107
internal const string AndroidSkipJavaStubGeneration = "AndroidSkipJavaStubGeneration";
100108

101109
public override bool RunTask ()
@@ -299,10 +307,23 @@ Dictionary<string, ITaskItem> MaybeGetArchAssemblies (Dictionary<AndroidTargetAr
299307

300308
void GenerateAdditionalProviderSources (NativeCodeGenState codeGenState, IList<string> additionalProviders)
301309
{
302-
if (androidRuntime != Xamarin.Android.Tasks.AndroidRuntime.MonoVM &&
303-
androidRuntime != Xamarin.Android.Tasks.AndroidRuntime.CoreCLR) {
304-
Log.LogDebugMessage ($"Skipping MonoRuntimeProvider generation for: {androidRuntime}");
305-
return;
310+
if (androidRuntime != Xamarin.Android.Tasks.AndroidRuntime.CoreCLR) {
311+
// Create additional runtime provider java sources.
312+
bool isMonoVM = androidRuntime == Xamarin.Android.Tasks.AndroidRuntime.MonoVM;
313+
string providerTemplateFile = isMonoVM ?
314+
"MonoRuntimeProvider.Bundled.java" :
315+
"NativeAotRuntimeProvider.java";
316+
string providerTemplate = GetResource (providerTemplateFile);
317+
318+
foreach (var provider in additionalProviders) {
319+
var contents = providerTemplate.Replace (isMonoVM ? "MonoRuntimeProvider" : "NativeAotRuntimeProvider", provider);
320+
var real_provider = isMonoVM ?
321+
Path.Combine (OutputDirectory, "src", "mono", provider + ".java") :
322+
Path.Combine (OutputDirectory, "src", "net", "dot", "jni", "nativeaot", provider + ".java");
323+
Files.CopyIfStringChanged (contents, real_provider);
324+
}
325+
} else {
326+
Log.LogDebugMessage ($"Skipping android.content.ContentProvider generation for: {androidRuntime}");
306327
}
307328

308329
// For NativeAOT, generate JavaInteropRuntime.java
@@ -360,7 +381,7 @@ IList<string> MergeManifest (NativeCodeGenState codeGenState, Dictionary<string,
360381
Debug = Debug,
361382
MultiDex = MultiDex,
362383
NeedsInternet = NeedsInternet,
363-
AndroidRuntime = AndroidRuntime,
384+
AndroidRuntime = androidRuntime,
364385
};
365386
// Only set manifest.VersionCode if there is no existing value in AndroidManifest.xml.
366387
if (manifest.HasVersionCode) {
@@ -394,7 +415,7 @@ IList<string> MergeManifest (NativeCodeGenState codeGenState, Dictionary<string,
394415
(List<TypeDefinition> allJavaTypes, List<TypeDefinition> javaTypesForJCW) = ScanForJavaTypes (resolver, tdCache, assemblies, userAssemblies, useMarshalMethods);
395416
var jcwContext = new JCWGeneratorContext (arch, resolver, assemblies.Values, javaTypesForJCW, tdCache, useMarshalMethods);
396417
var jcwGenerator = new JCWGenerator (Log, jcwContext) {
397-
CodeGenerationTarget = androidRuntime == Xamarin.Android.Tasks.AndroidRuntime.MonoVM ? JavaPeerStyle.XAJavaInterop1 : JavaPeerStyle.JavaInterop1
418+
CodeGenerationTarget = codeGenerationTarget,
398419
};
399420
bool success;
400421

‎src/Xamarin.Android.Build.Tasks/Tasks/WrapAssembliesAsSharedLibraries.cs‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@ public class WrapAssembliesAsSharedLibraries : AndroidTask
2424
[Required]
2525
public string AndroidBinUtilsDirectory { get; set; } = "";
2626

27+
[Required]
28+
public ITaskItem[] ResolvedRuntimePacks { get; set; } = Array.Empty<ITaskItem> ();
29+
2730
public bool IncludeDebugSymbols { get; set; }
2831

2932
[Required]
@@ -42,7 +45,7 @@ public class WrapAssembliesAsSharedLibraries : AndroidTask
4245

4346
public override bool RunTask ()
4447
{
45-
var wrapper_config = DSOWrapperGenerator.GetConfig (Log, AndroidBinUtilsDirectory, IntermediateOutputPath);
48+
var wrapper_config = DSOWrapperGenerator.GetConfig (Log, AndroidBinUtilsDirectory, ResolvedRuntimePacks, IntermediateOutputPath);
4649
var files = new PackageFileListBuilder ();
4750

4851
if (UseAssemblyStore)

‎src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Resources/Base/BuildReleaseArm64SimpleDotNet.apkdesc‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,34 +5,34 @@
55
"Size": 3036
66
},
77
"classes.dex": {
8-
"Size": 22444
8+
"Size": 22484
99
},
1010
"lib/arm64-v8a/lib__Microsoft.Android.Resource.Designer.dll.so": {
11-
"Size": 18296
11+
"Size": 18288
1212
},
1313
"lib/arm64-v8a/lib_Java.Interop.dll.so": {
14-
"Size": 86352
14+
"Size": 86688
1515
},
1616
"lib/arm64-v8a/lib_Mono.Android.dll.so": {
17-
"Size": 116920
17+
"Size": 117712
1818
},
1919
"lib/arm64-v8a/lib_Mono.Android.Runtime.dll.so": {
20-
"Size": 22408
20+
"Size": 22384
2121
},
2222
"lib/arm64-v8a/lib_System.Console.dll.so": {
23-
"Size": 24376
23+
"Size": 24392
2424
},
2525
"lib/arm64-v8a/lib_System.Linq.dll.so": {
2626
"Size": 25336
2727
},
2828
"lib/arm64-v8a/lib_System.Private.CoreLib.dll.so": {
29-
"Size": 634384
29+
"Size": 628216
3030
},
3131
"lib/arm64-v8a/lib_System.Runtime.dll.so": {
32-
"Size": 20040
32+
"Size": 20056
3333
},
3434
"lib/arm64-v8a/lib_System.Runtime.InteropServices.dll.so": {
35-
"Size": 21584
35+
"Size": 21480
3636
},
3737
"lib/arm64-v8a/lib_UnnamedProject.dll.so": {
3838
"Size": 20024
@@ -44,10 +44,10 @@
4444
"Size": 36440
4545
},
4646
"lib/arm64-v8a/libmonodroid.so": {
47-
"Size": 1501240
47+
"Size": 1524752
4848
},
4949
"lib/arm64-v8a/libmonosgen-2.0.so": {
50-
"Size": 3196512
50+
"Size": 3101112
5151
},
5252
"lib/arm64-v8a/libSystem.Globalization.Native.so": {
5353
"Size": 71976
@@ -62,7 +62,7 @@
6262
"Size": 165000
6363
},
6464
"lib/arm64-v8a/libxamarin-app.so": {
65-
"Size": 18264
65+
"Size": 19536
6666
},
6767
"META-INF/BNDLTOOL.RSA": {
6868
"Size": 1221
@@ -98,5 +98,5 @@
9898
"Size": 1904
9999
}
100100
},
101-
"PackageSize": 3111445
101+
"PackageSize": 3078677
102102
}

0 commit comments

Comments
 (0)