Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.tar.gz files not being correctly repacked with SignTool in .NET 8.0 #15232

Open
ellahathaway opened this issue Nov 8, 2024 · 0 comments
Open

Comments

@ellahathaway
Copy link
Member

It was revealed today that .tar.gz files are not being correctly repacked when signing with SignTool in .NET 8.0.

Here are examples of builds:

  • Build with correct .tar.gz (no runpacking/repacking of .tar.gz with SignTool)
  • Build with incorrect .tar.gz (unpacking/repacking of .tar.gz with SignTool)

Looking through the binlogs, it appears that the files get extracted correctly from the containers, but it is unclear why they do not get properly repacked.

We should investigate this, as this could negatively impact signing for repos who attempt to use the tooling for these files.

cc @tmat - Including you on this since I believe you wrote the unpacking/repacking tar infra that SignTool uses for these files. For context, I enabled the unpacking of .tar.gz files using the tooling you wrote with this 8.0 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant