Skip to content

Current sdk version (7.0*preview2) breaks dotnet/runtime tests, blocking the arcade update #9011

Closed
@radical

Description

@radical
  • This issue is blocking

The update PR for arcade in runtime breaks tests:

    System.IO.Compression.Tests.zip_CreateTests.CreateNormal_Unicode_Seekable [FAIL]
      System.IO.FileNotFoundException : Could not find file '/root/helix/work/workitem/e/ZipTestData/refzipfolders/unicode/한글.txt'.
      Stack Trace:
        /_/src/libraries/Common/src/Interop/Unix/Interop.IOErrors.cs(21,0): at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirectory, Func`2 errorRewriter)
        /_/src/libraries/Common/src/Interop/Unix/Interop.IOErrors.cs(28,0): at Interop.CheckIo(Error error, String path, Boolean isDirectory, Func`2 errorRewriter)
        /_/src/libraries/System.Private.CoreLib/src/Microsoft/Win32/SafeHandles/SafeFileHandle.Unix.cs(96,0): at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode, Func`4 createOpenException)
        /_/src/libraries/System.Private.CoreLib/src/Microsoft/Win32/SafeHandles/SafeFileHandle.Unix.cs(224,0): at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Permissions openPermissions, Int64& fileLength, Permissions& filePermissions, Func`4 createOpenException)
        /_/src/libraries/System.Private.CoreLib/src/Microsoft/Win32/SafeHandles/SafeFileHandle.Unix.cs(189,0): at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Permissions openPermissions, Func`4 createOpenException)
        /_/src/libraries/System.Private.CoreLib/src/System/IO/File.cs(167,0): at System.IO.File.OpenHandle(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
        /_/src/libraries/System.Private.CoreLib/src/System/IO/File.cs(250,0): at System.IO.File.ReadAllBytes(String path)
        /_/src/libraries/Common/tests/System/IO/Compression/StreamHelpers.cs(12,0): at StreamHelpers.CreateTempCopyStream(String path)
        /_/src/libraries/Common/tests/System/IO/Compression/ZipTestHelper.cs(338,0): at System.IO.Compression.Tests.ZipFileTestBase.CreateFromDir(String directory, Stream archiveStream, ZipArchiveMode mode, Boolean useSpansForWriting, Boolean writeInChunks)
        /_/src/libraries/System.IO.Compression/tests/ZipArchive/zip_CreateTests.cs(94,0): at System.IO.Compression.Tests.zip_CreateTests.CreateNormal_Unicode_Seekable()
        --- End of stack trace from previous location ---

This was fixed in dotnet/runtime#65886 , but the p2 sdk doesn't contain the fix. It was breaking for aspnetcore also, but IIUC, they updated to 7.0.100-preview.3.22159.27 which contains the fix.

This is blocking the arcade update, and bump to net7 .

Also, maybe an explicit test is needed for this case of zipping/unzipping unicode file paths.

cc @lewing

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions