Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP trace context transfer during a http redirect #27422

Open
dmitriyse opened this issue Nov 2, 2020 · 4 comments
Open

Add support for HTTP trace context transfer during a http redirect #27422

dmitriyse opened this issue Nov 2, 2020 · 4 comments
Labels
affected-very-few This issue impacts very few customers area-hosting Includes Hosting area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-httpclientfactory Includes: HttpClientFactory (some bugs also in Extensions repo) severity-minor This label is used by an internal tool
Milestone

Comments

@dmitriyse
Copy link

DotNet supports trace-context transfer through headers in the HTTP communication.
But when HTTP redirect occurs, the trace context information lost.
Currently, the W3C standard does not cover this case also, see: w3c/trace-context#438
But there are not too big amount of possible options.

Until HttpClients will start to support trace context headers preserving during HTTP redirects (which might never happen), query string can be used as a transport.

  1. W3C should standardize the query string parameter names, for example (they should not interfere with app-specific names and be short):
  • _tc_tid
  • _tc_pid
  • etc
  1. Asp.Net Core middleware that currently responsible for the Activity creation should also take into account the query string (not only headers)
  2. Microsoft.Extensions.Http library should be improved to instrument HttpClient if this feature is turned on.
  3. Microsoft.AspNet.TelemetryCorrelation library should be extended Feature Request: Add support for the query-string tracing context transport (to support http redirects). aspnet/Microsoft.AspNet.TelemetryCorrelation#78
  4. Until W3C introduces the names for the query string parameter names they should be configurable in all the above implementations.
@jkotalik
Copy link
Contributor

jkotalik commented Nov 4, 2020

cc @davidfowl @shirhatti

@BrennanConroy
Copy link
Member

BrennanConroy commented Nov 6, 2020

Triage: We will not support the query-string feature at this time.

We should verify our redirect behavior on the client though.

@BrennanConroy BrennanConroy added this to the Next sprint planning milestone Nov 9, 2020
@ghost
Copy link

ghost commented Nov 9, 2020

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@Tratcher Tratcher added affected-very-few This issue impacts very few customers enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-minor This label is used by an internal tool labels Nov 9, 2020 — with ASP.NET Core Issue Ranking
@ghost
Copy link

ghost commented Jul 14, 2021

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@amcasey amcasey added area-hosting Includes Hosting area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed feature-hosting labels Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected-very-few This issue impacts very few customers area-hosting Includes Hosting area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-httpclientfactory Includes: HttpClientFactory (some bugs also in Extensions repo) severity-minor This label is used by an internal tool
Projects
None yet
Development

No branches or pull requests

7 participants