Skip to content

Increase Grpc InteropTests timeout again, and quarantine EmptyUnary #61433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2025
Merged

Increase Grpc InteropTests timeout again, and quarantine EmptyUnary #61433

merged 2 commits into from
Apr 11, 2025

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Apr 10, 2025

Follow-up to #60471. The tests are still timing out occasionally.

@wtgodbe wtgodbe requested a review from BrennanConroy April 10, 2025 19:18
@ghost ghost added the area-grpc Includes: GRPC wire-up, templates label Apr 10, 2025
@wtgodbe wtgodbe requested a review from Copilot April 10, 2025 19:18
Copilot
Copilot AI reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@JamesNK
Copy link
Member

JamesNK commented Apr 10, 2025

I don't think they're timing out. I think something changed that caused them to start hanging.
You can try a longer timeout, but I think another fix is required.

@wtgodbe
Copy link
Member Author

wtgodbe commented Apr 10, 2025

I don't think they're timing out. I think something changed that caused them to start hanging.
You can try a longer timeout, but I think another fix is required.

Any idea what that could've been? InteropTests.InteropTests.EmptyUnary seems to be the the biggest culprit (16 of the last 19 instances, per dotnet/dnceng#5279), so I'll follow up on this by quarantining that one.

@wtgodbe wtgodbe changed the title Increase Grpc InteropTests timeout again Increase Grpc InteropTests timeout again, and quarantine EmptyUnary Apr 10, 2025
@BrennanConroy BrennanConroy mentioned this pull request Apr 10, 2025
Closed
@wtgodbe wtgodbe merged commit 11e812e into main Apr 11, 2025
24 of 27 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/Interop branch April 11, 2025 00:04
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview4 milestone Apr 11, 2025
@JamesNK
Copy link
Member

JamesNK commented Apr 11, 2025

I don't know. I'll investigate next time I'm on build ops 😄

@build-analysis build-analysis bot mentioned this pull request Apr 11, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@JamesNK JamesNK JamesNK approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

@mgravell mgravell Awaiting requested review from mgravell

Assignees

No one assigned

Labels

area-grpc Includes: GRPC wire-up, templates

Projects

None yet

Milestone

10.0-preview4

Development

Successfully merging this pull request may close these issues.

2 participants

@wtgodbe @JamesNK