From 045b5f9a4e537bded96c0bea9ab3720b9671bcc5 Mon Sep 17 00:00:00 2001
From: "Eric St. John" <ericstj@microsoft.com>
Date: Fri, 3 Aug 2018 09:26:48 -0700
Subject: [PATCH] Add some regression tests

---
 .../Rules/CombinationTest.cs                  | 64 +++++++++++++++++++
 .../Rules/PrivateFieldNamingRuleTests.cs      | 52 +++++++++++++++
 2 files changed, 116 insertions(+)

diff --git a/src/Microsoft.DotNet.CodeFormatting.Tests/Rules/CombinationTest.cs b/src/Microsoft.DotNet.CodeFormatting.Tests/Rules/CombinationTest.cs
index 426ed1b2..cc90c72e 100644
--- a/src/Microsoft.DotNet.CodeFormatting.Tests/Rules/CombinationTest.cs
+++ b/src/Microsoft.DotNet.CodeFormatting.Tests/Rules/CombinationTest.cs
@@ -357,5 +357,69 @@ public void RequiredRuntimeAttribute()
             ToggleRule(UsingLocationRule.Name, enabled: true);
             Verify(source, expected);
         }
+
+        [Fact]
+        public void Issue268()
+        {
+            var text = @"
+using System.Collections.Generic;
+
+internal class C
+{
+    private void M<TValue>()
+    {
+        Dictionary<string, Stack<TValue>> dict = new Dictionary<string, Stack<TValue>>();
+        dict.TryGetValue(""key"", out Stack<TValue> stack);
+    }
+}";
+
+            Verify(text, expected:text);
+        }
+
+        [Fact]
+        public void Issue272()
+        {
+            var text = @"
+using System.Collections.Generic;
+
+internal class C
+{
+
+        private object myVariable;
+
+        private void M()
+        {
+            Dictionary<string, object> dict = new Dictionary<string, object>()
+            {
+                { ""key"", new object() }
+            };
+
+            dict.TryGetValue(""key"", out object myVariable);
+
+            this.myVariable = myVariable;
+        }
+}";
+            var expected = @"
+using System.Collections.Generic;
+
+internal class C
+{
+    private object _myVariable;
+
+    private void M()
+    {
+        Dictionary<string, object> dict = new Dictionary<string, object>()
+            {
+                { ""key"", new object() }
+            };
+
+        dict.TryGetValue(""key"", out object myVariable);
+
+        _myVariable = myVariable;
+    }
+}";
+
+            Verify(text, expected);
+        }
     }
 }
diff --git a/src/Microsoft.DotNet.CodeFormatting.Tests/Rules/PrivateFieldNamingRuleTests.cs b/src/Microsoft.DotNet.CodeFormatting.Tests/Rules/PrivateFieldNamingRuleTests.cs
index 3a0404bb..20927d19 100644
--- a/src/Microsoft.DotNet.CodeFormatting.Tests/Rules/PrivateFieldNamingRuleTests.cs
+++ b/src/Microsoft.DotNet.CodeFormatting.Tests/Rules/PrivateFieldNamingRuleTests.cs
@@ -211,6 +211,58 @@ int M(C p)
 
                 Verify(text, expected);
             }
+
+            [Fact]
+            public void Issue258()
+            {
+                var text = @"
+class C
+{
+    private (string name, string value) myTuple;
+}
+";
+                var expected = @"
+class C
+{
+    private (string name, string value) _myTuple;
+}
+";
+
+                Verify(text, expected, runFormatter: false);
+            }
+
+            [Fact]
+            public void Issue241()
+            {
+                var text = @"
+class C
+{
+        private bool streamObjects;
+
+        /// <summary>
+        /// A collection in which objects that are written using the WriteError
+        /// method are accumulated if <see cref=""streamObjects"" /> is false.
+        /// </summary>
+        private List<string> errors;
+        
+}
+";
+                var expected = @"
+class C
+{
+        private bool _streamObjects;
+
+        /// <summary>
+        /// A collection in which objects that are written using the WriteError
+        /// method are accumulated if <see cref=""_streamObjects"" /> is false.
+        /// </summary>
+        private List<string> _errors;
+        
+}
+";
+
+                Verify(text, expected, runFormatter: false);
+            }
         }
 
         public sealed class VisualBasicFields : PrivateFieldNamingRuleTests