Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pre-build validation stage in this repo #1250

Open
lbussell opened this issue Apr 22, 2024 · 2 comments
Open

Disable pre-build validation stage in this repo #1250

lbussell opened this issue Apr 22, 2024 · 2 comments

Comments

@lbussell
Copy link
Contributor

There are no pre-build validation steps in this repo (docker-tools). Unless they are added, this step should be removed from our pipeline as it only wastes time. It also causes a warning when we try to upload test results when there are no tests to run.

if ($TestCategories.Contains("pre-build")) {
Write-Output "There are no pre-build tests"
}

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@github-project-automation github-project-automation bot moved this to Backlog in .NET Docker Apr 22, 2024
@lbussell lbussell changed the title Disable pre-build validation step in this repo Disable pre-build validation stage in this repo Apr 22, 2024
@lbussell
Copy link
Contributor Author

[Triage] It's important to keep this PreBuildValidation running in the eng-validation pipeline in order to exercise that pipeline code. We could synthesize some fake or empty trx file to test the publishing step.

We should also figure out why this warning isn't happening in the eng-validation internal pipeline while it is happening in the imagebuilder official pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant