Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove project name parameters from pipeline templates #1267

Open
mthalman opened this issue May 3, 2024 · 2 comments
Open

Remove project name parameters from pipeline templates #1267

mthalman opened this issue May 3, 2024 · 2 comments

Comments

@mthalman
Copy link
Member

mthalman commented May 3, 2024

This PR (#884) introduce a template pattern where internalProjectName and publicProjectName parameters were defined and passed around to templates rather than hardcoding the actual AzDO project names:

internalProjectName: null
publicProjectName: null

This pattern doesn't provide much value. In fact, it has negative value because developers need to ensure that these values get passed around through the template graph. Omitting this can lead to unintended behavior. We should consider removing these parameters and simply hardcoding the project names where they are needed.

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@lbussell lbussell moved this from Backlog to Current Release in .NET Docker May 9, 2024
@lbussell
Copy link
Contributor

[Triage] This is something we can work on incrementally - as we make changes to existing pipelines we should feel free to replace these variables where appropriate.

@lbussell lbussell moved this from Current Release to Backlog in .NET Docker Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants