Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug legs from CI build #6685

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

jander-msft
Copy link
Member

Summary

There is practically no utility in building the debug variants of the product in the official CI build:

  • The official CI build already does not test debug bits.
  • The public PR builds already build and run all of the latest TFM tests for debug binaries, which should provide enough coverage for new changes that introduce problems that would only show in debug builds.
  • Very little of the source code makes use of debug flags for altering product or test functionality.
  • Historically, very few issues have been caught by debug build legs in the CI build.

By removing debug variants from the CI build, compute utilization will be reduced and compliance tooling will not have to consider debug bits.

Release Notes Entry

@jander-msft jander-msft added servicing-patch Servicing fixes that is targeted for a patch release (0.0.x version) servicing-minor Servicing fixes that is targeted for a minor release (0.x.0 version) servicing-major Servicing fixes that is targeted for a major release (x.0.0 version) labels May 20, 2024
@jander-msft jander-msft enabled auto-merge (squash) May 20, 2024 21:11
@jander-msft jander-msft merged commit ce1b221 into dotnet:main May 20, 2024
25 checks passed
@jander-msft jander-msft deleted the ci-remove-debug branch May 20, 2024 22:18
@jander-msft
Copy link
Member Author

/backport to release/8.0

Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/dotnet-monitor/actions/runs/9165729655

@jander-msft
Copy link
Member Author

/backport to release/6.x

Copy link
Contributor

Started backporting to release/6.x: https://github.com/dotnet/dotnet-monitor/actions/runs/9165736923

Copy link
Contributor

@jander-msft backporting to release/6.x failed, the patch most likely resulted in conflicts.

Please backport manually using one of the below commands, followed by git am --continue once the merge conflict has been resolved.

PowerShell

(Invoke-WebRequest "https://github.com/dotnet/dotnet-monitor/commit/ce1b22124c629463ea63383bb51a05f0c56b2971.patch").Content | git am --3way --ignore-whitespace --exclude="documentation/**.md" --keep-non-patch

Bash

curl -sSL "https://github.com/dotnet/dotnet-monitor/commit/ce1b22124c629463ea63383bb51a05f0c56b2971.patch" | git am --3way --ignore-whitespace --exclude="documentation/**.md" --keep-non-patch

git am error output:

$ git am --3way --ignore-whitespace --exclude="documentation/**.md" --keep-non-patch changes.patch

Applying: Remove debug legs from CI build (#6685)
Using index info to reconstruct a base tree...
M	eng/pipelines/dotnet-monitor-official.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/dotnet-monitor-official.yml
CONFLICT (content): Merge conflict in eng/pipelines/dotnet-monitor-official.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Remove debug legs from CI build (#6685)
Error: The process '/usr/bin/git' failed with exit code 128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
servicing-major Servicing fixes that is targeted for a major release (x.0.0 version) servicing-minor Servicing fixes that is targeted for a minor release (0.x.0 version) servicing-patch Servicing fixes that is targeted for a patch release (0.0.x version)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants