-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove debug legs from CI build #6685
Conversation
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/dotnet-monitor/actions/runs/9165729655 |
/backport to release/6.x |
Started backporting to release/6.x: https://github.com/dotnet/dotnet-monitor/actions/runs/9165736923 |
@jander-msft backporting to release/6.x failed, the patch most likely resulted in conflicts. Please backport manually using one of the below commands, followed by PowerShell (Invoke-WebRequest "https://github.com/dotnet/dotnet-monitor/commit/ce1b22124c629463ea63383bb51a05f0c56b2971.patch").Content | git am --3way --ignore-whitespace --exclude="documentation/**.md" --keep-non-patch Bash curl -sSL "https://github.com/dotnet/dotnet-monitor/commit/ce1b22124c629463ea63383bb51a05f0c56b2971.patch" | git am --3way --ignore-whitespace --exclude="documentation/**.md" --keep-non-patch
$ git am --3way --ignore-whitespace --exclude="documentation/**.md" --keep-non-patch changes.patch
Applying: Remove debug legs from CI build (#6685)
Using index info to reconstruct a base tree...
M eng/pipelines/dotnet-monitor-official.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/dotnet-monitor-official.yml
CONFLICT (content): Merge conflict in eng/pipelines/dotnet-monitor-official.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Remove debug legs from CI build (#6685)
Error: The process '/usr/bin/git' failed with exit code 128 |
Summary
There is practically no utility in building the debug variants of the product in the official CI build:
By removing debug variants from the CI build, compute utilization will be reduced and compliance tooling will not have to consider debug bits.
Release Notes Entry