Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2024-43485 #7524

Closed
calexander3 opened this issue Oct 17, 2024 · 3 comments
Closed

CVE-2024-43485 #7524

calexander3 opened this issue Oct 17, 2024 · 3 comments

Comments

@calexander3
Copy link

CVE-2024-43485 is present in dotnet-monitor version 8.05 due to its use to System.Text.Json 8.0.4. This is fixed in #7473 but needs to be released

@calexander3 calexander3 added the bug Something isn't working label Oct 17, 2024
Copy link
Contributor

Welcome to dotnet-monitor!

Thanks for creating your first issue; let us know what you think of dotnet-monitor by filling out our survey.

@jander-msft
Copy link
Member

The dotnet-monitor tool packages do not contain the vulnerable System.Text.Json version but only have an entry in the dotnet-monitor.deps.json file. The library is provided by the shared runtime installation and is not part of the dotnet-monitor package itself.

If I install the tool locally:

> dotnet tool install --tool-path 'C:\tools' --version 8.0.5 dotnet-monitor
You can invoke the tool using the following command: dotnet-monitor
Tool 'dotnet-monitor' (version '8.0.5') was successfully installed.

and check for System.Text.Json.dll:

> cd C:\tools
> dir /s System.Text.Json.dll
 Volume in drive C is Local Disk
 Volume Serial Number is 0EE3-B1A0
File Not Found

The file does not exist.

However, if we check file contents:

> findstr /imspc:"System.Text.Json" *
.store\dotnet-monitor\8.0.5\dotnet-monitor\8.0.5\tools\net8.0\any\dotnet-monitor.deps.json
.store\dotnet-monitor\8.0.5\dotnet-monitor\8.0.5\tools\net8.0\any\extensions\AzureBlobStorage\dotnet-monitor-egress-azureblobstorage.deps.json
.store\dotnet-monitor\8.0.5\dotnet-monitor\8.0.5\tools\net8.0\any\extensions\S3Storage\dotnet-monitor-egress-s3storage.deps.json

It appears that the scanning tool that you've used is checking the entries in *.deps.json files rather than checking for the existence of the vulnerable files themselves. I would conclude that this is a false positive.

@jander-msft jander-msft removed the bug Something isn't working label Oct 17, 2024
@calexander3
Copy link
Author

Yes, that is true. It came from AWS ECR and listed the deps file as its detection method. Thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants