Fix Histogram/UpDownCounter Custom Tags Bug
#7697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reminder to tag this with |
kkeirstead
added
the
update-release-notes
wiktork
approved these changes
Dec 10, 2024
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/dotnet-monitor/actions/runs/12321196622 |
|
/backport to release/9.x |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Added aggregate payload and updowncounter * Added additional tests for histogram and up down counter tags
|
Started backporting to release/9.x: https://github.com/dotnet/dotnet-monitor/actions/runs/12321199470 |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Added aggregate payload and updowncounter * Added additional tests for histogram and up down counter tags
kkeirstead
added a commit
that referenced
this pull request
Dec 14, 2024
* Added aggregate payload and updowncounter * Added additional tests for histogram and up down counter tags Co-authored-by: kkeirstead <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During a refactor, an
AggregatePercentilePayloadconcept was built on top ofPercentilePayload, and was not properly updated inIsMeter. It would appear thatUpDownCounterPayloadwas also not updated correctly. Formatting tests were added for both to ensure tags were showing up as expected.Closes #7654
Release Notes Entry
Fixed an issue with custom tags not showing up for
HistogramandUpDownCountermeters