[release/8.0] Fix Histogram/UpDownCounter Custom Tags Bug

[github-actions]

Backport of #7697 to release/8.0

/cc @kkeirstead

[kkeirstead]

@jander-msft I think this actually doesn't get backported to 8.0 based on when custom tags were added - would this get backported to 8.x, or just solely 9.x (already done)?

[jander-msft]

@jander-msft I think this actually doesn't get backported to 8.0 based on when custom tags were added - would this get backported to 8.x, or just solely 9.x (already done)?

I agree this shouldn't be backported for custom tags since those were not added in 8.0. However, do the changes in the IsMeter method help? It looks like it might fix some aspect of the metric label calculation.

[kkeirstead]

@jander-msft I think this actually doesn't get backported to 8.0 based on when custom tags were added - would this get backported to 8.x, or just solely 9.x (already done)?

I agree this shouldn't be backported for custom tags since those were not added in 8.0. However, do the changes in the IsMeter method help? It looks like it might fix some aspect of the metric label calculation.

I think you're right...in the diagnostics repo those changes were introduced prior to the custom tags. In which case, from a branching perspective how should the divergence be handled if we want to keep the IsMeter changes for 8.0 but not the tests? Do you want me to just update this PR to remove the tests, or should there be a new PR that targets this branch? Or something else?

[jander-msft]

@jander-msft I think this actually doesn't get backported to 8.0 based on when custom tags were added - would this get backported to 8.x, or just solely 9.x (already done)?

I agree this shouldn't be backported for custom tags since those were not added in 8.0. However, do the changes in the IsMeter method help? It looks like it might fix some aspect of the metric label calculation.

I think you're right...in the diagnostics repo those changes were introduced prior to the custom tags. In which case, from a branching perspective how should the divergence be handled if we want to keep the IsMeter changes for 8.0 but not the tests? Do you want me to just update this PR to remove the tests, or should there be a new PR that targets this branch? Or something else?

Let's open a new PR that fixes the specific issue so that it gets its own entry in the release notes.