Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine the ComplianceReports and MetricDefinitions generators #3999

Open
danmoseley opened this issue May 25, 2023 · 2 comments · May be fixed by #5531
Open

Combine the ComplianceReports and MetricDefinitions generators #3999

danmoseley opened this issue May 25, 2023 · 2 comments · May be fixed by #5531
Labels
area-fundamentals enhancement This issue represents an ask for new feature or an enhancement to an existing one help wanted Up for grabs. We would accept a PR to help resolve this issue work in progress 🚧

Comments

@danmoseley
Copy link
Member

Let's combine both of these generators into MetadataExtractor which produces a single json document containing:

All logging methods in the assembly, with their data compliance annotations
All data models in the assembly which are annotation with data compliance annotations.
All metrics defined in the assembly
Along with any other schematized information we can extract programmatically.
@danmoseley danmoseley added help wanted Up for grabs. We would accept a PR to help resolve this issue untriaged labels May 25, 2023
@geeknoid geeknoid added enhancement This issue represents an ask for new feature or an enhancement to an existing one and removed untriaged labels Nov 27, 2023
@IbrahimMNada
Copy link

I will work on it

@IbrahimMNada
Copy link

Fixed at #5531

I have added a new generator called MetadataExtractor which handle both generators into one json.
its just a wrapper on top of the emitter of both Metric ,Compliance

I have also written full unit tests for it
Image

handled the three cases in which Metric was enabled or Compliance or both
Image

I have added new properties for them as well

MetadataReportOutputPath
GenerateMetadataReport

@IbrahimMNada IbrahimMNada linked a pull request Oct 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-fundamentals enhancement This issue represents an ask for new feature or an enhancement to an existing one help wanted Up for grabs. We would accept a PR to help resolve this issue work in progress 🚧
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Metadata reports generator (Issue #3999) IbrahimMNada/extensions
4 participants
@RussKie @danmoseley @geeknoid @IbrahimMNada