Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code coverage issues #4124

Open
martintmk opened this issue Jun 27, 2023 · 4 comments
Open

Code coverage issues #4124

martintmk opened this issue Jun 27, 2023 · 4 comments
Assignees
@RussKie
Labels
area-infrastructure work in progress 🚧

Comments

@martintmk
Copy link
Contributor

Description

In the PR #4108 I had to decrease the code-coverage from 100% to 98% because the build pipeline handles the code-coverage processing incorrectly.

The following lines:

extensions/src/Libraries/Microsoft.Extensions.Http.Resilience/FaultInjection/Internal/Log.cs

Line 16 in e70559f

public static partial void LogInjection(

extensions/src/Libraries/Microsoft.Extensions.Http.Resilience/Resilience/HttpClientBuilderExtensions.Resilience.cs

Line 31 in e70559f

public static IHttpResilienceStrategyBuilder AddResilienceHandler(

are correctly covered and tested, but the build fails.

There are also additional inconsistencies:

Reproduction Steps

Increase the min coverage to 100, the build fails:

extensions/src/Libraries/Microsoft.Extensions.Http.Resilience/Microsoft.Extensions.Http.Resilience.csproj

Line 22 in 6d67b41

<MinCodeCoverage>99</MinCodeCoverage>

Expected behavior

Increase the min coverage to 100, the build should succeed:

extensions/src/Libraries/Microsoft.Extensions.Http.Resilience/Microsoft.Extensions.Http.Resilience.csproj

Line 22 in 6d67b41

<MinCodeCoverage>99</MinCodeCoverage>

Actual behavior

The build fails when increasing the code-coverage to 100

extensions/src/Libraries/Microsoft.Extensions.Http.Resilience/Microsoft.Extensions.Http.Resilience.csproj

Line 22 in 6d67b41

<MinCodeCoverage>99</MinCodeCoverage>

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

Please
@martintmk martintmk mentioned this issue Jun 27, 2023
Merged
@RussKie
Copy link
Member

RussKie commented Jun 28, 2023 •
edited
Loading

As per recommendation we need to use PublishCodeCoverageResults@2 task. However, that task is currently broken.
I was advised the fix is in the pipeline, however, I'm yet to get clearer information on when the fix will be public.

/cc: @vinayakmsft

@RussKie RussKie removed the untriaged label Jun 28, 2023
@RussKie RussKie self-assigned this Jun 28, 2023
@RussKie
Copy link
Member

RussKie commented Jun 29, 2023 •
edited
Loading

@vinayakmsft advised me yesterday that it may be few weeks before the fix will be rolled out. In the interim as a workaround we can run the task on Windows agents and install .NET 7.

@RussKie RussKie mentioned this issue Jun 29, 2023
Closed
@ghost ghost removed the work in progress 🚧 label Oct 17, 2023
@geeknoid
Copy link
Member

Is this fixed?

@RussKie
Copy link
Member

RussKie commented Feb 25, 2025

No, PublishCodeCoverageResults@2 is still unusable, we're stuck with v1.

Related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RussKie RussKie

Labels
area-infrastructure work in progress 🚧
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use PublishCodeCoverageResults@2 task RussKie/extensions
3 participants
@RussKie @geeknoid @martintmk