Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadblocks on updating tests baselines #18289

Open
auduchinok opened this issue Feb 4, 2025 · 1 comment
Open

Roadblocks on updating tests baselines #18289

auduchinok opened this issue Feb 4, 2025 · 1 comment

Comments

@auduchinok
Copy link
Member

auduchinok commented Feb 4, 2025

There're some things that make it more difficult to contribute to this repo than it used to be.

Surface area tests

  • There're two different files need updating, the debug and release ones, despite their contents are the same
    • Let's have only one instead? It would save developers from switching the solution configuration and extra file manipulations
  • The actual and expected files are in different directories
    • Let's put the actual file next to the expected one, so it's easier to compare and replace them
  • The contents get reordered
    • Let's have a stable sorting, so it's easier to see the actual difference

ILVerify

@T-Gro
Copy link
Member

T-Gro commented Feb 4, 2025

I think all are sensible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New
Development

No branches or pull requests

2 participants