Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rollForward value #468

Open
siewers opened this issue May 17, 2024 · 5 comments · May be fixed by #472
Open

Support rollForward value #468

siewers opened this issue May 17, 2024 · 5 comments · May be fixed by #472
Labels
enhancement New feature or request

Comments

@siewers
Copy link

siewers commented May 17, 2024

Are there any plans to support the rollForward property in global.json?

If I set the version to 8.0.202 and rollForward to latestPatch, I would expect the script to install the (current) latest patch version 8.0.205, but that doesn't happen.

The same with the other values of the rollForward property.

@f-alizada
Copy link
Contributor

Hello @siewers, thank you for raising the ticket!
@baronfel Could you please take a look at the suggestion?

@f-alizada f-alizada self-assigned this May 17, 2024
@YuliiaKovalova YuliiaKovalova added the enhancement New feature or request label May 23, 2024
@js6pak js6pak linked a pull request Jun 4, 2024 that will close this issue
5 tasks
@baronfel
Copy link
Member

As a feature this makes sense, but I'm not sure that the existing redirect setup gives us the ability to actually handle all of the kinds of rollForward that exists today. I think to do this feature correctly we'd need to move to the releases json manifests as described in #463, but that involves a lot of json parsing that I'm loathe to do at the terminal.

@js6pak
Copy link

js6pak commented Jun 30, 2024

@baronfel

As a feature this makes sense, but I'm not sure that the existing redirect setup gives us the ability to actually handle all of the kinds of rollForward that exists today. I think to do this feature correctly we'd need to move to the releases json manifests as described in #463, but that involves a lot of json parsing that I'm loathe to do at the terminal.

As you can see in #472, the only two new redirects we would need is <major>.x for latestMinor and actually working latest regardless of STS/LTS for latestMajor.

@baronfel
Copy link
Member

I think these requests all make sense, but we'd need to tag in @rbhanda and @leecow to make any changes to the redirect scheme. So we'd need to start with a public accounting of the current redirect scheme and document the new additions.

@leecow
Copy link
Member

leecow commented Jul 30, 2024

The idea seems sound. The redirect scheme was documented a while back by the former dev owner, so I expect @baronfel and @YuliiaKovalova would tackle that. With respect to releases.json size implications on #472, we're in the process of implementing improvements to the release notes json files to help with the file size issue (dotnet/core#9417).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants