Release tag shouldn't be pushed until all dependent commits exist

[mthalman]

There have been cases where the release tag in this repo was pushed before the dependent commits exist in the related product repos. These commits are necessary in order to build a source tarball from this repo as documented in the readme.

This interferes with automated solutions by the community that would trigger when a new release tag is created. That would trigger a build to be run based on that tag. If the necessary commits don't yet exist, that build will fail.

Here's a concrete example with this month's 7.0.110 release:

The v7.0.110 tag was pushed at some point during the release process. But when that tag was pushed, running source build from installer produced this error:

Initialized empty Git repository in /src/source70/src/templating/.git/
fatal : remote error : upload-pack: not our ref 420b5a6d14c297042e101d94497ae6056dc262cf [/src/git/installer70/src/SourceBuild/tarball/BuildSourceBuildTarball.proj]
/src/git/installer70/src/SourceBuild/Arcade/tools/SourceBuildArcadeTarball.targets(165,5): error MSB3073: The command "git fetch --depth 1 origin 420b5a6d14c297042e101d94497ae6056dc262cf" exited with code 128. [/src/git/installer70/src/SourceBuild/tarball/BuildSourceBuildTarball.proj]

That's because the 420b5a6d14c297042e101d94497ae6056dc262cf commit didn't exist in the templating repo yet. That didn't happen until dotnet/templating#6928 was merged. Which is odd since these commits should have been pushed as orphaned commits anyway and not reliant upon merged PRs.

[mthalman]

@mmitche - I wanted to get your eyes on this. This is release infra stuff so not sure it belongs in this repo or who should take ownership.

[mmitche]

@mthalman This is 6.0/7.0 specific, ya? For 8.0 it would just be the dotnet/dotnet repo.

[mthalman]

Correct, this is 6.0/7.0.

[marcpopMSFT]

This is all automated from the release tools. Not sure where to route or who to assign to but not managed in installer itself.

[MichaelSimons]

There is a related issue in the private dotnet/release repo.

[marcpopMSFT]

Old issue triage: @mthalman is this still an issue?

[mthalman]

Closing in favor of https://github.com/dotnet/release/issues/419.