Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jit-diff (and maybe more) broken by recent runtime build change from windows_nt to windows #299

Open
AndyAyersMS opened this issue Nov 10, 2020 · 1 comment

Comments

@AndyAyersMS
Copy link
Member

Not sure yet how we fix this in a backwards compatible fashion.

index b44e826..a95e5ce 100755
--- a/src/jit-diff/jit-diff.cs
+++ b/src/jit-diff/jit-diff.cs
@@ -94,7 +94,7 @@ private static string GetBuildOS(string platformMoniker)
             switch (platformMoniker)
             {
                 case "Windows":
-                    return "Windows_NT";
+                    return "Windows";
                 case "Linux":
                     return "Linux";
                 case "OSX":

cc @dotnet/jit-contrib

@BruceForstall
Copy link
Member

Seems like it wouldn't be hard when computing defaults to try both old and new names. You can always specify full paths, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants