Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tiktoken implementation up-to-date with OpenAI reference implementation #7019

Open
stephentoub opened this issue Feb 20, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@stephentoub
Copy link
Member

The implementation at https://github.com/openai/tiktoken/commits/main/src/lib.rs has seen several improvements in the last year (eg openai/tiktoken#255), including a couple that claim perf wins around algorithmic complexity for long inputs. The comments in the source also cite ways of avoiding needing an LRU cache. We should ensure the C# implementation has all the corresponding goodness.

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged label Feb 20, 2024
@stephentoub
Copy link
Member Author

cc: @tarekgh

@tarekgh tarekgh self-assigned this Feb 20, 2024
@tarekgh tarekgh added enhancement New feature or request and removed untriaged New issue has not been triaged labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants