Fix for Frame PanGestureRecognizer is not working in Android #25239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
2 similar comments
This comment was marked as outdated.
This comment was marked as outdated.
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-16978
branch
from
72dbbd6 to
b3b1189
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Oct 29, 2024
| @@ -23,7 +23,8 @@ public bool HandleMotionEvent(IViewParent parent, MotionEvent motionEvent) | |||
| return false; | |||
| } | |||
|
|
|||
| return true; | |||
| // We should consider the InputTransparent for the VisualElement and decides to pass touch to the event | |||
| return ShouldPassThroughElement(); | |||
There was a problem hiding this comment.
I want to do more tests locally but ideally...
This implementation should be the same as the one in the Compatibility layer
In cases like the Frame, the missing part is the NotifyFakeHandling that impact in the behavior of the DispatchTouchEvent method from an y View.
|
/rebase |
github-actions
bot
force-pushed
the
fix-16978
branch
from
04b3340 to
7c0c7f0
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
sheiksyedm
added
the
partner/syncfusion
|
Since Frame is now officially deprecated lets not spend too much time on this. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
The touch events in the Frame control on the Android platform are not handled correctly. Specifically, in the FrameRenderer, the touch event handler consistently returns true, which suppresses the default behavior and prevents the expected response to touch interactions.
Description of Change
The MotionEventHelper class contains a method called ShouldPassThroughElement(), which is designed to evaluate whether a touch event should be passed through an element. Utilizing this method will ensure correct touch handling, thereby resolving the issue
Issues Fixed
Fixes #16978
Output Video
Frame.pan.not.working.mp4
Frame.pan.working.mp4