ScrollView CrossPlatformMeasure - refactor #27085
Open
+49
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
Jan 14, 2025
|
|
||
| if (double.IsInfinity(widthConstraint)) | ||
| { | ||
| widthConstraint = result.Width; | ||
| widthConstraint = contentSize.Width; |
There was a problem hiding this comment.
Do we want to delete both of these if checks on Android and Windows?
There was a problem hiding this comment.
Without them AdjustForFill doesn't work correctly
|
@kubaflo Does this PR potentially improve performance please? |
I hope so, but I didn't measure anything. The main idea was to uniform the code across the platforms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refactored the
CrossPlatformMeasuremethod for ScrollViewHandler on Android and Windows, so that it is similar to the iOS one introduced by this PR #26763@PureWeen